page query string is blank when using the sorting

[yulolimum]

Clicking on a table heading appends query strings to the URL in order to sort the data items. It should add a sort_field and sort_direction key to the params (which it does). However, it also adds a page key which is blank.

Here are relevant code snippets:

We are passing in opts with no page key here:

We are setting the page key here - in this case it's nil because i dont have page in the assigns:

This results in the following error:

Am I missing something? Do I have to set the page key on the conn in the controller?

[yulolimum]

Hmmm... I decided to remove the page key manually and now i'm getting a different error:

{:ok, filter} = Filtrex.parse_params(@filtrex, Map.delete(params, "page") || %{})

getting...

Did something get generated incorrectly?

[yulolimum]

@darinwilson - do you have issues with sorting? If not, which project are you on so I can compare controllers?

[yulolimum]

I ended up adding my own sort since I'm not really using the sidebar widgets for filtering.

    page =
      User
      |> order_by(^sort_order(params["sort_direction"], params["sort_field"]))
      |> paginate(Repo, params, @pagination)

  defp sort_order(direction, field) when is_binary(direction) and is_binary(field) do
    [{String.to_atom(direction), String.to_atom(field)}]
  end
  defp sort_order(_, _), do: [desc: :inserted_at]

leaving this open just so someone can verify that's torch isn't having issues out of the box.

[danielberkompas]

I'm pretty sure I encountered this in CrossConnect. Gonna copy over some of my fixes from over there.