assets not building in phoenix 1.5.1

[jalberto]

If I understand Torch correctly, assets are built into priv and serve from there as static files (by default priv/static is ignored by git so it makes sense).

Following README and generating a new context, I got not torch assets in my priv dir.]

am I missing a step?

[jalberto]

So modifying original webpack config css line to /\.(sass|scss|css)$/ made the trick (the original version was not expecting sass but scss

[cpjolicoeur]

@jalberto Thanks for bringing this to our attention.

We probably can/should update our output files to something that is recognized by the default webpack configs so users don't need to make this change.

I assume you are referring to this line here?

[jalberto]

yes, that line, To be fair, I would prefer that phoenix accepted `sass` format by default

…

On Mon, 27 Apr 2020 at 21:11, Craig P Jolicoeur ***@***.***> wrote: @jalberto <https://github.com/jalberto> Thanks for bringing this to our attention. We probably can/should update our output files to something that is recognized by the default webpack configs so users don't need to make this change. I assume you are referring to this line here <https://github.com/mojotech/torch/blob/master/test/support/apps/phx1_5/assets/webpack.config.js#L37> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYMV72F5TBUX3IXUBCJK3ROXKGFANCNFSM4MR2XC3A> .

[cpjolicoeur]

@jalberto I agree. I'd suggest maybe opening a Pull Request against the webpack config template in Phoenix to add sass to the regex check. Is that something you are open to tackling or would you prefer us to do it?

[cpjolicoeur]

@jalberto As far as Torch is concerned, I don't think our asset files are doing anything special that require the SASS syntax vs the SCSS syntax. Torch, as a library, could convert our templates to SCSS and.

Your personally preference to use SASS over SCSS on a Phoenix project would probably fall outside the scope of what Torch as a library does, and as such, would probably require the same customization to the webpack config or an expansion of the official phoenix template.

I haven't opened any kind of Pull Request to the Phoenix project, but I did ask about their potential interest in the change here.

[jalberto]

fair point :) will open an issue in Phoenix repo.

Thanks for your time!

[cpjolicoeur]

Hey, @jalberto, sorry my mind clearly isn't working well today, but Torch doesnt really generate any sass files that your Phoenix application would access. Torch ships with pre-compiled CSS and JS files that are linked to from the default torch layout that is generated.

Your Phoenix project would never directly interact with the Sass files in the library, only the generated CSS and JS file.

[jalberto]

I was just thinking about that, then I don't understand why it worked once I changed the webpack config, maybe it was somehow cached :/ Thanks for you time anyway

…

On Tue, 28 Apr 2020 at 20:49, Craig P Jolicoeur ***@***.***> wrote: Hey, @jalberto <https://github.com/jalberto>, sorry my mind clearly isn't working well today, but Torch doesnt really generate any sass files that your Phoenix application would access. Torch ships with pre-compiled CSS and JS files that are linked to from the default torch layout that is generated. Your Phoenix project would never directly interact with the Sass files in the library, only the generated CSS and JS file. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#158 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYMVZNO4NABRAZUZ5CMYLRO4PZ5ANCNFSM4MR2XC3A> .