-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize CSS file should only affect torch markup #13
Comments
@yulianglukhenko Do you have a preference on which option to pursue? I'm inclined just make things more explicit in the docs, as we're probably going to want to be more specific about how folks can customize the screens. I think we'd just want to say:
I think that would fix this issue and let the user know how to customize anything they see. |
More docs is always great; however, this doesn't fix the issue that some of the torch styles are affecting your custom app's styles if you include them after your styles. If you include them before, then your custom app's styles will affect the torch styles. I can do a PR to fix this probably tomorrow. I'll probably use the namespaced normalize approach from thesis. |
@yulolimum did this ever get done? |
[#13] Namespace normalize CSS
Here's the issue.
The app css files are included before torch so you can style torch using my_app variables / mixins / etc. Torch include a css reseter that isn't namespaced.
Two options:
or...
Here's an example of how you can namespace the normalize file.
Add an ID to the body in the
admin.html
layout.Use a mixin with the normalize styles: https://github.com/infinitered/thesis-phoenix/blob/master/web/static/css/_mixins/_normalize.scss (or create your own, stripping html and body styles).
Include the mixin on the body ID you created: https://github.com/infinitered/thesis-phoenix/blob/master/web/static/css/base/_global.sass#L9
** Thesis files are for reference
The text was updated successfully, but these errors were encountered: