Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #289: Handle processParent in mojos which support it. #813

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Resolves #289: Handle processParent in mojos which support it. #813

merged 1 commit into from
Nov 17, 2022

Conversation

andrzejj0
Copy link
Contributor

Also:

  • added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo
  • added unit tests and integration tests
  • some refactoring

More steps towards folding ForceReleases and UseReleases will follow. Also, I see it's possible to reuse parts of the common base class used for lastest versions/releases, but this will follow in future PRs.

@andrzejj0
Copy link
Contributor Author

@slawekjaranowski please review

@andrzejj0 andrzejj0 force-pushed the issue-289-apply-parent branch from 1d5b043 to 87a6d2f Compare November 10, 2022 10:59
@andrzejj0
Copy link
Contributor Author

I have updated it a bit to fold UseReleasesMojo with ForceReleasesMojo a bit further, but that's about it in this PR, I'll continue this subject in a separate PR.

Another point to consider: I think #134 is not limited to that one mojo, but may be present everywhere -- to be checked and possibly fixed.

@andrzejj0 andrzejj0 force-pushed the issue-289-apply-parent branch 6 times, most recently from 82eda30 to e5fdcf1 Compare November 11, 2022 13:36
@andrzejj0
Copy link
Contributor Author

andrzejj0 commented Nov 11, 2022 •
edited
Loading

Sorry about these multiple updates today, I think that's it for this PR.

Now it all looks lean and clean. Almost all mojos updating versions consist of an almost similar method (which by the way could also be folded), and a (small) business method, providing the provider function, instructing useLatestVersions how exactly it should retrieve the latest version.

Another area to improve is the VersionDetails interface, where instead of passing arrays and operating on arrays, which is memory and cycle consuming and sometimes wasteful if we're only interested in e.g. the last version, streams could be used with filters defines on those streams. But this is for another PR.

@andrzejj0 andrzejj0 force-pushed the issue-289-apply-parent branch from e5fdcf1 to e421730 Compare November 13, 2022 16:49
@andrzejj0
Copy link
Contributor Author

@slawekjaranowski rebased. Please review.

@andrzejj0
Resolves mojohaus#289: Handle processParent in mojos which support it.
8ce921e 
Also:
- added failIfNotReplaced to ForceReleasesMojo as a first steps towards converging with UseReleasesMojo
- enhanced documentation on UseReleasesMojo#allowRangeMatching
- streamlined UseReleasesMojo in order to converge it with ForceReleasesMojo and then fold further with other similar mojos
- added unit tests and integration tests
- some refactoring
@andrzejj0 andrzejj0 force-pushed the issue-289-apply-parent branch from e421730 to 8ce921e Compare November 16, 2022 17:01
@slawekjaranowski
Copy link
Member

As I assume - after it PR #289 an issue #288 - can be closed - right?

@slawekjaranowski slawekjaranowski linked an issue Nov 16, 2022 that may be closed by this pull request
use-next-releases does not respect processParent setting #288
Closed
@slawekjaranowski slawekjaranowski added this to the 2.14.0 milestone Nov 16, 2022
@andrzejj0
Copy link
Contributor Author

Correct

@slawekjaranowski slawekjaranowski merged commit 2c78f43 into mojohaus:master Nov 17, 2022
@andrzejj0 andrzejj0 mentioned this pull request Nov 17, 2022
Closed
This was referenced Dec 31, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

use-next-releases does not respect processParent setting
2 participants
@andrzejj0 @slawekjaranowski