-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changerecorder #416
Changerecorder #416
Conversation
Is anyone else able to see the logs of the failing checks? I get a generic "Sorry, we weren't able to download the logs" error message. Edit: Managed to get the logs. Working on the integration test failures now. |
Additionally: Do we have a set of code style settings I can load into my IDE so that I don't reformat things I didn't touch? I notice a few of the annotations have been broken across lines; I used the published Maven code style settings file in IDEA, but evidently that doesn't quite match what Mojohaus projects use. |
1d94e04
to
cb26b82
Compare
This is ready for review. |
This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Hi @io7m Would you be willing to post an example output and rebase your PR? |
I'll attempt to rebase this next weekend. I had completely forgotten this still existed, and didn't see the notification above. |
@bmarwell There's an example output file (as a test case) as the last file in the commit:
There's an XSD schema included. |
This provides a ChangeRecorder interface that logs changes to a machine-readable XML file whenever a pom.xml file is updated. Affects: mojohaus#356
@bmarwell This has been rebased! |
Apparently this PR is at risk of being closed by the stale PR workflow. I'm commenting here in the hope that the comment stops this from happening. 🙂 |
This isn't getting merged in any time soon, right? |
Thank you! This one has been quite a long time coming. 😆 |
This provides a ChangeRecorder interface that logs changes to a machine-readable XML file whenever a pom.xml file is updated. The XML format is fully specified with an XSD schema. By default, no logging of changes occurs.
Change recording can be enabled by specifying the
changeRecorderFormat
andchangeRecorderOutputFile
properties (the latter of which logs to aversions-changes.xml
file in the output directory by default). IfchangeRecorderFormat = none
(the default), no logging occurs. IfchangeRecorderFormat = xml
, the changes will be logged in the XML format.Ticket: #356