Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make output more clean and readable or add an option for that #4

Closed
php-coder opened this issue Aug 19, 2018 · 0 comments · Fixed by #14
Closed

Make output more clean and readable or add an option for that #4

php-coder opened this issue Aug 19, 2018 · 0 comments · Fixed by #14
Labels
enhancement
Milestone
2.1.0

Comments

@php-coder
Copy link

Hi, thank you for supporting this plugin!

I'd like to suggest a little improvement: could we make make the output is more readable/easy to understand from the first sight?

Compare the output from the old plugin:

[INFO] --- native2ascii-maven-plugin:1.0-beta-1:native2ascii (default) @ mystamps ---
[INFO] Includes: [**/*.properties]
[INFO] Excludes: []
[INFO] Processing /home/travis/build/php-coder/mystamps/target/classes/ru/mystamps/i18n/SpringSecurityMessages_ru.properties
[INFO] Processing /home/travis/build/php-coder/mystamps/target/classes/ru/mystamps/i18n/MailTemplates_ru.properties
[INFO] Processing /home/travis/build/php-coder/mystamps/target/classes/ru/mystamps/i18n/SpringSecurityMessages.properties
[INFO] Processing /home/travis/build/php-coder/mystamps/target/classes/ru/mystamps/i18n/MailTemplates.properties
[INFO] Processing /home/travis/build/php-coder/mystamps/target/classes/ru/mystamps/i18n/ValidationMessages.properties
[INFO] Processing /home/travis/build/php-coder/mystamps/target/classes/ru/mystamps/i18n/ValidationMessages_ru.properties
[INFO] Processing /home/travis/build/php-coder/mystamps/target/classes/ru/mystamps/i18n/Messages_ru.properties
[INFO] Processing /home/travis/build/php-coder/mystamps/target/classes/ru/mystamps/i18n/Messages.properties

and the new one:

[INFO] --- native2ascii-maven-plugin:2.0.1:resources (utf8-to-latin1) @ mystamps ---
[INFO] Includes: [**/*.properties]
[INFO] Excludes: []
[INFO] Processing /home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/ValidationMessages_ru.properties
[INFO] Converting: '/home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/ValidationMessages_ru.properties' to: '/home/travis/build/php-coder/mystamps/target/classes/classes/ru/mystamps/i18n/ValidationMessages_ru.properties'
[INFO] Processing /home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/MailTemplates.properties
[INFO] Converting: '/home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/MailTemplates.properties' to: '/home/travis/build/php-coder/mystamps/target/classes/classes/ru/mystamps/i18n/MailTemplates.properties'
[INFO] Processing /home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/ValidationMessages.properties
[INFO] Converting: '/home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/ValidationMessages.properties' to: '/home/travis/build/php-coder/mystamps/target/classes/classes/ru/mystamps/i18n/ValidationMessages.properties'
[INFO] Processing /home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/MailTemplates_ru.properties
[INFO] Converting: '/home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/MailTemplates_ru.properties' to: '/home/travis/build/php-coder/mystamps/target/classes/classes/ru/mystamps/i18n/MailTemplates_ru.properties'
[INFO] Processing /home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/SpringSecurityMessages_ru.properties
[INFO] Converting: '/home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/SpringSecurityMessages_ru.properties' to: '/home/travis/build/php-coder/mystamps/target/classes/classes/ru/mystamps/i18n/SpringSecurityMessages_ru.properties'
[INFO] Processing /home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/Messages.properties
[INFO] Converting: '/home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/Messages.properties' to: '/home/travis/build/php-coder/mystamps/target/classes/classes/ru/mystamps/i18n/Messages.properties'
[INFO] Processing /home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/SpringSecurityMessages.properties
[INFO] Converting: '/home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/SpringSecurityMessages.properties' to: '/home/travis/build/php-coder/mystamps/target/classes/classes/ru/mystamps/i18n/SpringSecurityMessages.properties'
[INFO] Processing /home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/Messages_ru.properties
[INFO] Converting: '/home/travis/build/php-coder/mystamps/src/main/resources/ru/mystamps/i18n/Messages_ru.properties' to: '/home/travis/build/php-coder/mystamps/target/classes/classes/ru/mystamps/i18n/Messages_ru.properties'

The differences are:

  • more messages
  • messages are longer

I'd suggest something like that:

[INFO] --- native2ascii-maven-plugin:2.0.1:resources (utf8-to-latin1) @ mystamps ---
[INFO] Includes: [**/*.properties]
[INFO] Excludes: []
[INFO] Source Dir: src/main/resources/ru/mystamps/i18n
[INFO] Target Dir: target/classes/ru/mystamps/i18n
[INFO] Converting: Messages.properties
[INFO] Converting: Messages_ru.properties

WDYT?
dmatej added a commit that referenced this issue May 3, 2023
@dmatej
Resolves #4 - reduced noise in logs; changes in tests
8dc80d2 
- now prints file conversions just once, everything else is in debug
- added test for typical testResources usage
- the test for typical usage changed from inplace to resources

Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej linked a pull request May 3, 2023 that will close this issue
Resolves #4 - reduced noise in logs; changes in tests #14
Merged
@dmatej dmatej closed this as completed in #14 May 3, 2023
dmatej added a commit that referenced this issue May 3, 2023
@dmatej
Resolves #4 - reduced noise in logs; changes in tests
523ebae 
- now prints file conversions just once, everything else is in debug
- added test for typical testResources usage
- the test for typical usage changed from inplace to resources

Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej added this to the 2.1.0 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Resolves #4 - reduced noise in logs; changes in tests mojohaus/native2ascii-maven-plugin
2 participants
@php-coder @dmatej