Add sequence diagram section to docs/README; use PlantUML proxy to render svg #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e diags Add Sequence Diagrams section to the Docs/README.md; create a new sequence diagram .md file for each sequence diagram referenced from README; incorporate PlantUML proxy service to render the sequence diagrams within each new sequence page.
Fix color names
|
|
lewisdaly
pushed a commit
that referenced
this pull request
Mar 11, 2021
* chore: update deps * docs: UML sequence for P2PTransaction * chore: bring back deps * docs: update UML sequence for P2PTransaction * doc: rename state to pendingVerifyAuthorization, add question about notification of transactionRequestState:ACCEPTED * Add sequence diagram section to docs/README; use PlantUML proxy to render svg (#51) * Sequence diagrams linked in README; PlantUML proxy render for sequence diags Add Sequence Diagrams section to the Docs/README.md; create a new sequence diagram .md file for each sequence diagram referenced from README; incorporate PlantUML proxy service to render the sequence diagrams within each new sequence page. * Update PISPTransactionApi.puml Fix color names Co-authored-by: Paweł Marzec <[email protected]> * fix: #Light->#LightBlue * doc: drop AUTH-SERVICE in favor of abstract DFSP backend * chore: regenerate package-lock.json * chore: update deps * doc: add error scenario for failed Authorization * doc: add png * doc: fix issues Co-authored-by: Miller Abel <[email protected]>
eoln
added a commit
that referenced
this pull request
Mar 15, 2021
* chore: update deps * docs: UML sequence for P2PTransaction * chore: bring back deps * docs: update UML sequence for P2PTransaction * doc: rename state to pendingVerifyAuthorization, add question about notification of transactionRequestState:ACCEPTED * Add sequence diagram section to docs/README; use PlantUML proxy to render svg (#51) * Sequence diagrams linked in README; PlantUML proxy render for sequence diags Add Sequence Diagrams section to the Docs/README.md; create a new sequence diagram .md file for each sequence diagram referenced from README; incorporate PlantUML proxy service to render the sequence diagrams within each new sequence page. * Update PISPTransactionApi.puml Fix color names Co-authored-by: Paweł Marzec <[email protected]> * fix: #Light->#LightBlue * doc: drop AUTH-SERVICE in favor of abstract DFSP backend * chore: regenerate package-lock.json * chore: update deps * doc: add error scenario for failed Authorization * doc: add png * doc: fix issues * refactor: drop dfspId from config, use plural name for requests * refactor: use plural for requests, drop dfspId, add TODOS * refactor: drop dfspId from config * feat: sdk-requests to group all sdk related requests * test: add requestToPay scenario * doc: update plurar Requests * refactor: rename SDKRequest to SDKRequests * refactor: new set of requests accessors for RequestToolkit * refactor: pispTransactionModel to use SDKRequests * refactor: InboundAuthorizationsModel to use PISPBackendRequests * refactor: to use new requests * test: fix broken units * refactor: inbound transactions * test: fix broken mock of RequestToolkit * feat: new config params and fixing integration tests * fix: url paths * test: fix warning about HelloGet handler * chore: replace sdk-scheme-adapter master/pisp docker image with master one * ci: add ttk to wait4 * ci: add sdk-scheme-adapter to wait4 * test: fix port * doc: update PISPTransaction svg file * docs: add some todos * refactor: rename endpoint to match uml sequences Co-authored-by: Miller Abel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sequence diagrams section to docs/README with links to new ...md file for each sequence diagram. Created initial versions of the sequence diagram md files with link through PlantUML proxy to the raw sequence diagram .puml files in docs/sequence/...
Corrected color name errors in PISPTransactionAPI.puml that prevented rendering.
*** I had previously pushed these two commits erroneously to Mojaloop -> Master. I reset the head on Mojaloop -> Master and the commits are now incoming through a pull request from my fork, as I originally intended.