feat(mojaloop/#3533): v15.2.0 release fixes #129

oderayi · 2023-10-19T16:02:19Z

feat(mojaloop/#3533): v15.2.0 release fixes - mojaloop/project#3533

Added retry logic to funds-in account balance request to fix timing issues
Replaced hard-coded delay time in CGS provisioning with DELAY_FUNDS_IN environment variable
Added delays to some tests to fix timing issues
Switched some post-request requests to HTTP temporarily to bypass websocket failures in TTK backend

…elay time in CGS provisioning with DELAY_FUNDS_IN env var

…rfsp Get Status Request after deposit

…fsp Get Status Request after deposit

… delays where necessary to fix timing bugs

collections/hub/golden_path/settlement_management/mixed_settlement_model.json

mdebarros

Some additional comments.

collections/hub/provisioning/MojaloopSims_Onboarding/noresponsepayeefsp.json

collections/hub/provisioning/MojaloopSims_Onboarding/payeefsp.json

collections/hub/provisioning/MojaloopSims_Onboarding/payerfsp.json

...tions/hub/golden_path/settlement_management/Settlement-management-primary-currency-test.json

...ctions/hub/golden_path/settlement_management/Settlement-management-second-currency-test.json

…ment_model.json Co-authored-by: Miguel de Barros <[email protected]>

…icipants/active_and_inactive_participant.json Co-authored-by: Miguel de Barros <[email protected]>

…anagement-primary-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

…anagement-second-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

…icipants/active_and_inactive_participants_accounts.json Co-authored-by: Miguel de Barros <[email protected]>

…ve_notification_positive_testfsp1_testfsp2.json Co-authored-by: Miguel de Barros <[email protected]>

…anagement-primary-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

…equest requests using HTTP endpoints and add comment

collections/hub/provisioning/MojaloopSims_Onboarding/payeefsp.json

collections/hub/provisioning/MojaloopSims_Onboarding/noresponsepayeefsp.json

collections/hub/provisioning/MojaloopSims_Onboarding/payeefsp.json

mdebarros

+1

oderayi added 3 commits October 19, 2023 13:37

feat: Add retry logic to funds in balance request. Replay hardcoded d…

0121a43

…elay time in CGS provisioning with DELAY_FUNDS_IN env var

chore: restore deleted files

82b5857

fix: add more condition to the retry logic for a failing test

f1b4de8

oderayi changed the title ~~fix(mojaloop/#3533): fix provisioning bug~~ feat(mojaloop/#3533): fix provisioning bug Oct 19, 2023

oderayi mentioned this pull request Oct 19, 2023

feat(mojaloop/#3533): v15.2.0 release fixes #128

Closed

oderayi added 3 commits October 19, 2023 17:19

fix: update provisioning

93123ad

fix: update provisioning

bc7c796

fix: fix retry logic

db60087

oderayi changed the title ~~feat(mojaloop/#3533): fix provisioning bug~~ feat(mojaloop/#3533): v15.2.0 release fixes Oct 19, 2023

aaronreynoza previously approved these changes Oct 20, 2023

View reviewed changes

fix: bumb RETRY_MAX_WAIT_IN_MS

508ce38

oderayi dismissed aaronreynoza’s stale review via 508ce38 October 20, 2023 09:14

feat: Add delay to 'GET /participants/limits before updating NDC'

ceb2ccc

oderayi mentioned this pull request Oct 23, 2023

Provisioning and GP test failing because of Funds In timing problems mojaloop/project#3579

Closed

1 task

oderayi added 5 commits October 24, 2023 15:23

fix(mojaloop/#3533): Bump default wait time to 1sec for request: paye…

2043b75

…rfsp Get Status Request after deposit

fix(mojaloop/#3533): Bump default wait time to 2sec for request: paye…

2e2dec5

…rfsp Get Status Request after deposit

fix(mojaloop/#3533): Set default wait time to 1sec for request: payer…

bf79625

…fsp Get Status Request after deposit

fix(mojaloop/3533): Use HTTP TestAPI endpoints for failing tests. Add…

a334f26

… delays where necessary to fix timing bugs

fix(mojaloop/#3533): update hub collections

5a3c426

oderayi requested review from aaronreynoza, mdebarros and vijayg10 October 30, 2023 08:56

mdebarros reviewed Oct 30, 2023

View reviewed changes

oderayi and others added 6 commits October 30, 2023 12:11

Update collections/hub/golden_path/settlement_management/mixed_settle…

7a1b2b9

…ment_model.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/settlement_management/mixed_settle…

fdc3da0

…ment_model.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/settlement_management/mixed_settle…

c0a9a72

…ment_model.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/settlement_management/mixed_settle…

c9c6970

…ment_model.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/feature_tests/Active_Inactive_part…

1902279

…icipants/active_and_inactive_participant.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/settlement_management/Settlement-m…

e991a08

…anagement-primary-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

oderayi and others added 16 commits October 30, 2023 12:18

Update collections/hub/golden_path/settlement_management/Settlement-m…

21ab86e

…anagement-second-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/settlement_management/Settlement-m…

1c804e4

…anagement-second-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/settlement_management/Settlement-m…

c3e6bcf

…anagement-second-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/settlement_management/Settlement-m…

04b2dca

…anagement-second-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/feature_tests/Active_Inactive_part…

a8bf444

…icipants/active_and_inactive_participants_accounts.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/feature_tests/Active_Inactive_part…

8c79864

…icipants/active_and_inactive_participants_accounts.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/feature_tests/post_scenarios/reser…

9c413e1

…ve_notification_positive_testfsp1_testfsp2.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/settlement_management/Settlement-m…

1cc8a57

…anagement-primary-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/settlement_management/Settlement-m…

901be4b

…anagement-primary-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

Update collections/hub/golden_path/settlement_management/Settlement-m…

eb682bc

…anagement-primary-currency-test.json Co-authored-by: Miguel de Barros <[email protected]>

fix(mojaloop/#3533): Temporarily comment out WS connections for postR…

8c21387

…equest requests using HTTP endpoints and add comment

fix(mojaloop/#3533): Update retry logic to check account balance value

5740c8d

fix(mojaloop/#3533): Temporarily comment out WS connection

e441ae7

fix(mojaloop/#3533): Update retry logic to cater for actual balances

bf09409

fix(mojaloop/#3533): Remove unneeded retry logic

0b971f0

doc(mojaloop/#3533): Add back removed README

f0c8a52

mdebarros reviewed Oct 30, 2023

View reviewed changes

doc(mojaloop/#3533): fix variable typo

8f85bf1

oderayi requested a review from mdebarros October 31, 2023 06:42

mdebarros approved these changes Oct 31, 2023

View reviewed changes

oderayi merged commit 0e62e1a into master Oct 31, 2023

oderayi mentioned this pull request Oct 31, 2023

RC candidate for the next Mojaloop release (post v15.1.0) mojaloop/project#3533

Closed

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(mojaloop/#3533): v15.2.0 release fixes #129

feat(mojaloop/#3533): v15.2.0 release fixes #129

oderayi commented Oct 19, 2023 •

edited

Loading

mdebarros left a comment

mdebarros left a comment

feat(mojaloop/#3533): v15.2.0 release fixes #129

feat(mojaloop/#3533): v15.2.0 release fixes #129

Conversation

oderayi commented Oct 19, 2023 • edited Loading

mdebarros left a comment

Choose a reason for hiding this comment

mdebarros left a comment

Choose a reason for hiding this comment

oderayi commented Oct 19, 2023 •

edited

Loading