Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#3078): get /transfers callback is wrong for transf #109

Conversation

mdebarros
Copy link
Member

feat(mojaloop/#3078): get /transfers callback is wrong for expired transfers - mojaloop/project#3078

  • updated transfer negative scenarios in the GP test collection to conform to FSPIOP Spec and code changes to the Central-Ledger

…ansfers

feat(mojaloop/#3078): get /transfers callback is wrong for expired transfers - mojaloop/project#3078
- updated transfer negative scenarios in the GP test collection to conform to FSPIOP Spec and code changes to the Central-Ledger
@mdebarros mdebarros marked this pull request as ready for review January 26, 2023 15:46
Copy link
Contributor

@kleyow kleyow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@mdebarros mdebarros changed the title feat(mojaloop/#3078): get /transfers callback is wrong for expired transfers feat(mojaloop/#3078): get /transfers callback is wrong for transf Jan 27, 2023
@mdebarros mdebarros merged commit d637d89 into master Jan 27, 2023
@mdebarros mdebarros deleted the feat/#3078-GET-transfers-callback-is-wrong-for-expired-transfers branch January 27, 2023 08:30
kleyow pushed a commit that referenced this pull request Feb 3, 2023
* Added assertions for tests

* added negative test case

* feat(mojaloop/#3078): get /transfers callback is wrong for transf (#109)

feat(mojaloop/#3078): get /transfers callback is wrong for expired transfers - mojaloop/project#3078
- updated transfer negative scenarios in the GP test collection to conform to FSPIOP Spec and code changes to the Central-Ledger

* Updated TC2 with correct TTK references

* Added checks for default accounts

* Added test case for regular transfer

* Updated type for MAS3 TC

---------

Co-authored-by: Miguel de Barros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants