Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/2949): [sdk-scheme-adapter][private-shared-lib] Update private-shared-lib to use v0.2 #414

Merged
merged 2 commits into from
Nov 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .ncurc.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
## Add a TODO comment indicating the reason for each rejected dependency upgrade added to this list, and what should be done to resolve it (i.e. handle it through a story, etc).
reject: [
## v0.2.0 of the these libraries introduces various changes to base classes used in `private-shared-lib`.
## https://github.com/mojaloop/platform-shared-lib.
## Story to resolve issue: https://github.com/mojaloop/project/issues/2949
'@mojaloop/platform-shared-lib-nodejs-kafka-client-lib',
'@mojaloop/platform-shared-lib-messaging-types-lib',
## This should be removed and upgraded as part of this PR: https://github.com/mojaloop/sdk-scheme-adapter/pull/391
'@mojaloop/api-snippets'
]
2 changes: 1 addition & 1 deletion modules/api-svc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
},
"dependencies": {
"@koa/cors": "^4.0.0",
"@mojaloop/api-snippets": "^16.0.4",
"@mojaloop/api-snippets": "^16.0.5",
"@mojaloop/central-services-error-handling": "^12.0.5",
"@mojaloop/central-services-logger": "^11.0.1",
"@mojaloop/central-services-metrics": "^12.0.5",
Expand Down
2 changes: 1 addition & 1 deletion modules/outbound-command-event-handler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"snapshot": "standard-version --no-verify --skip.changelog --prerelease snapshot --releaseCommitMessageFormat 'chore(snapshot): {{currentTag}}'"
},
"dependencies": {
"@mojaloop/api-snippets": "^16.0.4",
"@mojaloop/api-snippets": "^16.0.5",
"@mojaloop/central-services-shared": "^17.3.1",
"@mojaloop/logging-bc-client-lib": "^0.1.15",
"@mojaloop/logging-bc-public-types-lib": "^0.1.12",
Expand Down
2 changes: 1 addition & 1 deletion modules/outbound-domain-event-handler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"snapshot": "standard-version --no-verify --skip.changelog --prerelease snapshot --releaseCommitMessageFormat 'chore(snapshot): {{currentTag}}'"
},
"dependencies": {
"@mojaloop/api-snippets": "^16.0.4",
"@mojaloop/api-snippets": "^16.0.5",
"@mojaloop/logging-bc-client-lib": "^0.1.15",
"@mojaloop/logging-bc-public-types-lib": "^0.1.12",
"@mojaloop/sdk-scheme-adapter-private-shared-lib": "workspace:^",
Expand Down
6 changes: 3 additions & 3 deletions modules/private-shared-lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
"snapshot": "standard-version --no-verify --skip.changelog --prerelease snapshot --releaseCommitMessageFormat 'chore(snapshot): {{currentTag}}'"
},
"dependencies": {
"@mojaloop/api-snippets": "^16.0.4",
"@mojaloop/api-snippets": "^16.0.5",
"@mojaloop/central-services-shared": "^17.3.1",
"@mojaloop/logging-bc-public-types-lib": "^0.1.12",
"@mojaloop/platform-shared-lib-messaging-types-lib": "^0.1.1",
"@mojaloop/platform-shared-lib-nodejs-kafka-client-lib": "^0.1.1",
"@mojaloop/platform-shared-lib-messaging-types-lib": "^0.2.16",
"@mojaloop/platform-shared-lib-nodejs-kafka-client-lib": "^0.2.13",
"ajv": "^8.11.0",
"redis": "^4.4.0",
"uuid": "^9.0.0"
Expand Down
4 changes: 3 additions & 1 deletion modules/private-shared-lib/src/events/base_event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

'use strict';
// import { v4 as uuidv4 } from 'uuid'
import { IMessage, IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessage, IMessageHeader } from '@module-types';
import { getEnumValues } from '../utils';

export enum EventType {
Expand Down Expand Up @@ -121,6 +121,8 @@ export class BaseEvent {
key: this._data.key,
timestamp: this._data.timestamp,
headers: this._data.headers,
partition: null,
offset: null,
};
return message;
}
Expand Down
2 changes: 1 addition & 1 deletion modules/private-shared-lib/src/events/command_event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

'use strict';

import { IMessage } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessage } from '@module-types';
import { IEventData, EventType, BaseEvent, IEventValue } from './base_event';

export type ICommandEventData = Omit<IEventData, 'type'>;
Expand Down
2 changes: 1 addition & 1 deletion modules/private-shared-lib/src/events/domain_event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

'use strict';

import { IMessage } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessage } from '@module-types';
import { IEventData, EventType, BaseEvent, IEventValue } from './base_event';

export type IDomainEventData = Omit<IEventData, 'type'>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface IPrepareSDKOutboundBulkResponseCmdEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { BulkQuoteErrorResponse, BulkQuoteResponse } from '../../types';

export interface IProcessBulkQuotesCallbackCmdEvtData {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { BulkTransferErrorResponse, BulkTransferResponse } from '../../types';

export interface IProcessBulkTransfersCallbackCmdEvtData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { PartyErrorResponse, PartyResponse } from '@module-types';

export interface IProcessPartyInfoCallbackCmdEvtData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { SDKSchemeAdapter } from '@mojaloop/api-snippets';
import { randomUUID } from 'crypto';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { SDKSchemeAdapter } from '@mojaloop/api-snippets';

export interface IProcessSDKOutboundBulkAcceptQuoteCmdEvtData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface IProcessSDKOutboundBulkPartyInfoRequestCmdEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface IProcessSDKOutboundBulkQuotesRequestCmdEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { SDKSchemeAdapter } from '@mojaloop/api-snippets';
import { randomUUID } from 'crypto';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface IProcessSDKOutboundBulkResponseSentCmdEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface IProcessSDKOutboundBulkTransfersRequestCompleteCmdEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { CommandEvent } from '../command_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface IProcessSDKOutboundBulkTransfersRequestCmdEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export type IBulkQuotesCallbackProcessedDmEvtData = {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { BulkQuoteErrorResponse, BulkQuoteResponse } from '@module-types';

export interface IBulkQuotesCallbackReceivedDmEvtData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { SDKSchemeAdapter } from '@mojaloop/api-snippets';

export type IBulkQuotesRequestedDmEvtData = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export type IBulkTransfersCallbackProcessedDmEvtData = {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { BulkTransferErrorResponse, BulkTransferResponse } from '@module-types';

export type IBulkTransfersCallbackReceivedDmEvtData = {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export type IBulkTransfersProcessedDmEvtData = {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { SDKSchemeAdapter } from '@mojaloop/api-snippets';

export type IBulkTransfersRequestedDmEvtData = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface IPartyInfoCallbackProcessedDmEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { PartyErrorResponse, PartyResponse } from '@module-types';

export interface IPartyInfoCallbackReceivedDmEvtData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { PartyInfoRequest } from '@module-types';

export interface IPartyInfoRequestedDmEvtData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface ISDKOutboundBulkAcceptPartyInfoProcessedDmEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { SDKSchemeAdapter } from '@mojaloop/api-snippets';

export interface ISDKOutboundBulkAcceptPartyInfoReceivedDmEvtData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { SDKSchemeAdapter } from '@mojaloop/api-snippets';

export type CoreConnectorBulkAcceptPartyInfoRequestIndividualTransferResult = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export type ISDKOutboundBulkAcceptQuoteProcessedDmEvtData = {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { SDKSchemeAdapter } from '@mojaloop/api-snippets';

export interface ISDKOutboundBulkAcceptQuoteReceivedDmEvtData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { SDKSchemeAdapter } from '@mojaloop/api-snippets';

// TODO: Current dfspInboundAPI is outdated and its better to add the core connector API to the API snippets library as single source of truth.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface ISDKOutboundBulkAutoAcceptPartyInfoRequestedDmEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface ISDKOutboundBulkAutoAcceptQuoteCompletedDmEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

'use strict';

import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { DomainEvent } from '../domain_event';

export interface ISDKOutboundBulkPartyInfoRequestProcessedDmEvtData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface ISDKOutboundBulkPartyInfoRequestedDmEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';

export interface ISDKOutboundBulkQuotesRequestProcessedDmEvtData {
bulkId: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
'use strict';

import { DomainEvent } from '../domain_event';
import { IMessageHeader } from '@mojaloop/platform-shared-lib-messaging-types-lib';
import { IMessageHeader } from '@module-types';
import { SDKSchemeAdapter } from '@mojaloop/api-snippets';
import { randomUUID } from 'crypto';

Expand Down
Loading