fix: update party callback handling (#416)

mojaloop · Nov 7, 2022 · e51aa79 · e51aa79
1 parent 09083a8
commit e51aa79
Show file tree

Hide file tree

Showing 7 changed files with 212 additions and 124 deletions.
diff --git a/modules/api-svc/package.json b/modules/api-svc/package.json
@@ -89,18 +89,18 @@
     "random-word-slugs": "^0.1.6",
     "redis": "^4.4.0",
     "uuidv4": "^6.2.13",
-    "ws": "^8.10.0"
+    "ws": "^8.11.0"
   },
   "devDependencies": {
-    "@babel/core": "^7.19.6",
-    "@babel/preset-env": "^7.19.4",
+    "@babel/core": "^7.20.2",
+    "@babel/preset-env": "^7.20.2",
     "@redocly/openapi-cli": "^1.0.0-beta.94",
     "@types/jest": "^29.2.2",
     "babel-jest": "^29.2.2",
-    "eslint": "^8.26.0",
+    "eslint": "^8.27.0",
     "eslint-config-airbnb-base": "^15.0.0",
     "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jest": "^27.1.3",
+    "eslint-plugin-jest": "^27.1.4",
     "jest": "^29.2.2",
     "jest-junit": "^14.0.1",
     "nock": "^13.2.9",

diff --git a/modules/outbound-command-event-handler/package.json b/modules/outbound-command-event-handler/package.json
@@ -49,7 +49,7 @@
     "express": "^4.18.2",
     "openapi-backend": "^5.5.0",
     "redis": "^4.4.0",
-    "swagger-ui-express": "^4.5.0",
+    "swagger-ui-express": "^4.6.0",
     "yamljs": "^0.3.0"
   },
   "devDependencies": {
@@ -64,7 +64,7 @@
     "@typescript-eslint/eslint-plugin": "^5.42.0",
     "@typescript-eslint/parser": "^5.42.0",
     "copyfiles": "^2.4.1",
-    "eslint": "^8.26.0",
+    "eslint": "^8.27.0",
     "jest": "^29.2.2",
     "nodemon": "^2.0.20",
     "npm-check-updates": "^16.3.16",

diff --git a/...and-event-handler/src/domain/bulk_transaction_agg/handlers/process_party_info_callback.ts b/...and-event-handler/src/domain/bulk_transaction_agg/handlers/process_party_info_callback.ts
@@ -130,16 +130,18 @@ export async function handleProcessPartyInfoCallbackCmdEvt(
                 for await (const individualTransferId of allIndividualTransferIds) {
                     const individualTransferData = await bulkTransactionAgg
                         .getIndividualTransferById(individualTransferId);
-                    if(individualTransferData.partyResponse) {
-                        individualTransferResults.push({
-                            homeTransactionId: individualTransferData.request.homeTransactionId,
-                            transactionId: individualTransferData.id,
-                            to: individualTransferData.partyResponse?.party,
-                            lastError: individualTransferData.partyResponse?.errorInformation && {
-                                mojaloopError: individualTransferData.partyResponse?.errorInformation,
-                            },
-                        });
-                    }
+
+                    // Individual transfers where `partyResult.currentState` does
+                    // not match SDKOutboundTransferState.COMPLETED will have no `partyResponse`
+                    // set. `transactionId` and `homeTransaction` still need to be set.
+                    individualTransferResults.push({
+                        homeTransactionId: individualTransferData.request.homeTransactionId,
+                        transactionId: individualTransferData.id,
+                        to: individualTransferData.partyResponse?.party,
+                        lastError: individualTransferData.partyResponse?.errorInformation && {
+                            mojaloopError: individualTransferData.partyResponse?.errorInformation,
+                        },
+                    });
                 }
                 const sdkOutboundBulkAcceptPartyInfoRequestedDmEvt = new SDKOutboundBulkAcceptPartyInfoRequestedDmEvt({
                     bulkId: bulkTransactionAgg.bulkId,

diff --git a/modules/outbound-domain-event-handler/package.json b/modules/outbound-domain-event-handler/package.json
@@ -47,7 +47,7 @@
         "express": "^4.18.2",
         "openapi-backend": "^5.5.0",
         "redis": "^4.4.0",
-        "swagger-ui-express": "^4.5.0",
+        "swagger-ui-express": "^4.6.0",
         "yamljs": "^0.3.0"
     },
     "devDependencies": {
@@ -62,7 +62,7 @@
         "@typescript-eslint/eslint-plugin": "^5.42.0",
         "@typescript-eslint/parser": "^5.42.0",
         "copyfiles": "^2.4.1",
-        "eslint": "^8.26.0",
+        "eslint": "^8.27.0",
         "jest": "^29.2.2",
         "nodemon": "^2.0.20",
         "npm-check-updates": "^16.3.16",

diff --git a/modules/private-shared-lib/package.json b/modules/private-shared-lib/package.json
@@ -38,7 +38,7 @@
   },
   "devDependencies": {
     "@types/node": "^18.11.9",
-    "eslint": "^8.26.0",
+    "eslint": "^8.27.0",
     "jest": "^29.2.2",
     "npm-check-updates": "^16.3.16",
     "replace": "^1.2.2",

diff --git a/package.json b/package.json
@@ -67,7 +67,7 @@
     "wait-4-docker": "node ./scripts/_wait4_all.js"
   },
   "dependencies": {
-    "nx": "15.0.9",
+    "nx": "15.0.10",
     "tslib": "^2.4.1"
   },
   "devDependencies": {
@@ -77,7 +77,7 @@
     "@typescript-eslint/eslint-plugin": "^5.42.0",
     "@typescript-eslint/parser": "^5.42.0",
     "audit-ci": "^6.3.0",
-    "eslint": "^8.26.0",
+    "eslint": "^8.27.0",
     "eslint-config-airbnb-typescript": "^17.0.0",
     "eslint-plugin-import": "latest",
     "husky": "^8.0.1",