fix: await transaction commit and rollback and avoid unhandledPromise error

package.json

@@ -138,7 +138,7 @@
     "audit-ci": "^7.1.0",
     "eslint": "8.16.0",
     "eslint-config-standard": "17.1.0",
-    "eslint-plugin-jest": "28.8.0",
+    "eslint-plugin-jest": "28.8.1",
     "jest": "29.7.0",
     "jest-junit": "16.0.0",
     "npm-check-updates": "17.1.0",

src/model/fxQuotes.js

@@ -231,7 +231,7 @@ class FxQuotesModel {
       histTimer({ success: false, queryName: 'handleFxQuoteRequest' })
       this.log.error('error in handleFxQuoteRequest', err)
       if (txn) {
-        txn.rollback(err)
+        await txn.rollback().catch(() => {})
       }
       await this.handleException(fspiopSource, fxQuoteRequest.conversionRequestId, err, headers, childSpan)
     } finally {
@@ -380,7 +380,7 @@ class FxQuotesModel {
       this.log.error('error in handleFxQuoteUpdate', err)
       const fspiopSource = headers[ENUM.Http.Headers.FSPIOP.SOURCE]
       if (txn) {
-        txn.rollback(err)
+        await txn.rollback().catch(() => {})
       }
       await this.handleException(fspiopSource, conversionRequestId, err, headers, childSpan)
     } finally {
@@ -534,7 +534,7 @@ class FxQuotesModel {
         })
 
         // commit the txn to the db
-        txn.commit()
+        await txn.commit()
       }
 
       await childSpan.audit({ headers, params: { conversionRequestId } }, EventSdk.AuditEventAction.start)
@@ -545,7 +545,7 @@ class FxQuotesModel {
       histTimer({ success: false, queryName: 'handleFxQuoteError' })
       this.log.error('error in handleFxQuoteError', err)
       if (txn) {
-        txn.rollback(err)
+        await txn.rollback().catch(() => {})
       }
       await this.handleException(fspiopSource, conversionRequestId, err, headers, childSpan)
     } finally {

src/model/quotes.js

@@ -417,7 +417,7 @@ class QuotesModel {
     } catch (err) {
       log.error('error in handleQuoteRequest:', err)
       if (txn) {
-        txn.rollback(err)
+        await txn.rollback().catch(() => {})
       }
 
       const fspiopError = ErrorHandler.ReformatFSPIOPError(err)
@@ -711,7 +711,7 @@ class QuotesModel {
       // internal-error
       this.writeLog(`Error in handleQuoteUpdate: ${getStackOrInspect(err)}`)
       if (txn) {
-        txn.rollback(err)
+        await txn.rollback().catch(() => {})
       }
       const fspiopError = ErrorHandler.ReformatFSPIOPError(err)
       const state = new EventSdk.EventStateMetadata(EventSdk.EventStatusType.failed, fspiopError.apiErrorCode.code, fspiopError.apiErrorCode.message)
@@ -857,7 +857,7 @@ class QuotesModel {
         })
 
         // commit the txn to the db
-        txn.commit()
+        await txn.commit()
       }
       // create a new object to represent the error
       const fspiopError = ErrorHandler.CreateFSPIOPErrorFromErrorInformation(error)
@@ -871,7 +871,7 @@ class QuotesModel {
       // internal-error
       this.writeLog(`Error in handleQuoteError: ${getStackOrInspect(err)}`)
       if (txn) {
-        txn.rollback(err)
+        await txn.rollback().catch(() => {})
       }
       const fspiopError = ErrorHandler.ReformatFSPIOPError(err)
       const state = new EventSdk.EventStateMetadata(EventSdk.EventStatusType.failed, fspiopError.apiErrorCode.code, fspiopError.apiErrorCode.message)
@@ -998,9 +998,10 @@ class QuotesModel {
     const childSpan = span.getChild('qs_quote_sendErrorCallback')
     try {
       await childSpan.audit({ headers, params: { quoteId } }, EventSdk.AuditEventAction.start)
-      await this.sendErrorCallback(fspiopSource, fspiopError, quoteId, headers, childSpan, true)
+      const result = await this.sendErrorCallback(fspiopSource, fspiopError, quoteId, headers, childSpan, true)
       histTimer({ success: true, queryName: 'quote_handleException' })
       log.info('handleException is done')
+      return result
     } catch (err) {
       // any-error
       // not much we can do other than log the error

test/unit/mocks.js

@@ -118,7 +118,7 @@ const fxQuoteMocks = {
   }),
   db: ({
     commit = jest.fn().mockResolvedValue({}),
-    rollback = jest.fn(),
+    rollback = jest.fn(() => Promise.reject(new Error('DB error'))),
     getParticipant = jest.fn().mockResolvedValue({}),
     getParticipantEndpoint = jest.fn().mockResolvedValue(undefined),
     createFxQuoteResponse = jest.fn().mockResolvedValue({}),

test/unit/model/quotes.test.js

@@ -124,7 +124,7 @@ describe('QuotesModel', () => {
     })
     mockTransaction = {
       commit: jest.fn(),
-      rollback: jest.fn()
+      rollback: jest.fn(() => Promise.reject(new Error('DB error')))
     }
     mockChildSpan = {
       injectContextToHttpRequest: jest.fn(opts => opts),