chore: address follow up iso comments (#385)

* chore: address follow up iso comments

* chore: bump deps for date validation

README.md

@@ -210,4 +210,7 @@ Event objects must have a type property, and an optional params property. There
 ```
 ## Additional Notes
 
-N/A
+- Since the first pass ISO20022 support doesn't cover all resources at this time
+  `api-swagger-iso20022-parties.yaml` still uses fspiop for resources that
+  weren't in the iso scope on the first pass example `/bulkQuotes`.
+  This is to ensure no regression for resources that aren't yet covered.

package.json

@@ -111,10 +111,10 @@
     "@hapi/inert": "7.1.0",
     "@hapi/vision": "7.0.3",
     "@mojaloop/central-services-error-handling": "13.0.3",
-    "@mojaloop/central-services-health": "15.0.0",
+    "@mojaloop/central-services-health": "15.0.1",
     "@mojaloop/central-services-logger": "11.5.2",
     "@mojaloop/central-services-metrics": "12.4.3",
-    "@mojaloop/central-services-shared": "18.15.1",
+    "@mojaloop/central-services-shared": "18.15.2",
     "@mojaloop/central-services-stream": "11.4.2",
     "@mojaloop/event-sdk": "14.1.2",
     "@mojaloop/inter-scheme-proxy-cache-lib": "2.3.1",

src/handlers/QuotingHandler.js

@@ -71,7 +71,13 @@ class QuotingHandler {
 
     try {
       span = await this.createSpan(requestData)
-      await model.handleQuoteRequest(headers, payload, span, this.cache, originalPayload)
+      await model.handleQuoteRequest({
+        headers,
+        quoteRequest: payload,
+        span,
+        cache: this.cache,
+        originalPayload
+      })
       this.logger.debug('handlePostQuotes is done')
     } catch (err) {
       this.logger.error(`error in handlePostQuotes partition:${requestData.partition}, offset:${requestData.offset}:`, err)
@@ -97,7 +103,7 @@ class QuotingHandler {
       span = await this.createSpan(requestData)
       const result = isError
         ? await model.handleQuoteError(headers, quoteId, payload.errorInformation, span, originalPayload)
-        : await model.handleQuoteUpdate(headers, quoteId, payload, span, originalPayload)
+        : await model.handleQuoteUpdate({ headers, quoteId, payload, span, originalPayload })
       this.logger.debug('handlePutQuotes is done', { result })
     } catch (err) {
       this.logger.error(`error in handlePutQuotes partition:${requestData.partition}, offset:${requestData.offset}:`, err)

src/model/fxQuotes.js

@@ -170,8 +170,7 @@ class FxQuotesModel {
    *
    * @returns {undefined}
    */
-  async handleFxQuoteRequest (headers, fxQuoteRequest, span, originalPayload = fxQuoteRequest, cache) {
-    // todo: remove default value for originalPayload (added just for passing tests)
+  async handleFxQuoteRequest (headers, fxQuoteRequest, span, originalPayload, cache) {
     const histTimer = Metrics.getHistogram(
       'model_fxquote',
       'handleFxQuoteRequest - Metrics for fx quote model',

src/model/quotes.js

@@ -194,8 +194,7 @@ class QuotesModel {
    *
    * @returns {object} - returns object containing keys for created database entities
    */
-  async handleQuoteRequest (headers, quoteRequest, span, cache, originalPayload) {
-    // todo: update method signature to use object destructuring
+  async handleQuoteRequest ({ headers, quoteRequest, span, cache, originalPayload }) {
     const histTimer = Metrics.getHistogram(
       'model_quote',
       'handleQuoteRequest - Metrics for quote model',
@@ -542,8 +541,7 @@ class QuotesModel {
    *
    * @returns {object} - object containing updated entities
    */
-  async handleQuoteUpdate (headers, quoteId, payload, span, originalPayload) {
-    // todo: update method signature to use object destructuring
+  async handleQuoteUpdate ({ headers, quoteId, payload, span, originalPayload }) {
     const histTimer = Metrics.getHistogram(
       'model_quote',
       'handleQuoteUpdate - Metrics for quote model',

test/mocks.js

@@ -283,7 +283,7 @@ const headersDto = ({
 } = {}) => Object.freeze({
   accept: interoperabilityHeaderDto(resource, version, isIsoApi),
   'content-type': interoperabilityHeaderDto(resource, version, isIsoApi),
-  date: new Date().toISOString(),
+  date: new Date().toUTCString(),
   'fspiop-source': source,
   'fspiop-destination': destination
 })