Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quoting service is failing when trying to send errorCallbacks due to validation failures #988

Closed
2 tasks done
mdebarros opened this issue Sep 25, 2019 · 1 comment
Closed
2 tasks done

Quoting service is failing when trying to send errorCallbacks due to validation failures #988

mdebarros opened this issue Sep 25, 2019 · 1 comment
Assignees
@mdebarros
Milestone
Sprint 8.1

Comments

@mdebarros
Copy link
Member

mdebarros commented Sep 25, 2019 •
edited by elnyry-sam-k
Loading

Summary:
Quoting service is failing when trying to send error callbacks due to validation failures.

This is due to some bugs in the code that the handleException & sendErrorCallback expects request.headers but are not being passed in.

This results in the incorrect exception being sent through.

Severity:
High

Priority:
Critical

Expected Behavior

Steps to Reproduce

  1. Send a PUT Quote request with an accept header so that validation fails

Specifications

  • Component (if known): quoting-service
  • Version: v7.4.x
  • Platform: all
  • Subsystem:
  • Type of testing:
  • Bug found/raised by: @mdebarros

Tasks:

  • Error endpoints fixed
  • Config to support debugging, etc

Notes:

  • Severity when opened: High
  • Priority when opened: Critical
@mdebarros mdebarros added the bug label Sep 25, 2019
@mdebarros mdebarros self-assigned this Sep 25, 2019
mdebarros added a commit to mdebarros/quoting-service that referenced this issue Sep 25, 2019
@mdebarros
Fixes for mojaloop/project#988
79321e8
@mdebarros mdebarros mentioned this issue Sep 25, 2019
Merged
mdebarros added a commit to mojaloop/quoting-service that referenced this issue Sep 25, 2019
@mdebarros
Maintenance updates to quoting service (#44)
825d900 
- Added configs for knex pool configurations
- Replaced any console.log/info with the mojaloop logger
- Bumped version to v8.1.0
- Bumped up dependencies to latest versions (still pending updates for central-services-shared to remove the Kafka dependency)
- Fixes for mojaloop/project#988 included. Error callbacks should send properly with the header being passed into the respective methods.
- Added detailed health end-point which reports on datastore store if simpleRoutingMode is disabled.
@elnyry-sam-k elnyry-sam-k added this to the Sprint 8.1 milestone Sep 26, 2019
@elnyry-sam-k
Copy link
Member

Fixed in v8.1.1-snapshot, verified..

@elnyry-sam-k elnyry-sam-k mentioned this issue Oct 11, 2019
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
None yet
Projects
None yet
Milestone
Sprint 8.1
Development

No branches or pull requests
2 participants
@elnyry-sam-k @mdebarros