Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk-scheme-adapter v11.18.5 release failing on startup #2433

Closed
mdebarros opened this issue Aug 26, 2021 · 0 comments · Fixed by mojaloop/sdk-scheme-adapter#282
Closed

sdk-scheme-adapter v11.18.5 release failing on startup #2433

mdebarros opened this issue Aug 26, 2021 · 0 comments · Fixed by mojaloop/sdk-scheme-adapter#282
Assignees
@mdebarros
Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Milestone
Sprint 15.2

Comments

@mdebarros
Copy link
Member

Summary:

SDK-scheme-adapter v11.18.5 release fails on startup with the following log:

throw err;
^

Error: Cannot find module '@mojaloop/central-services-logger'
Require stack:
- /src/node_modules/@mojaloop/central-services-shared/src/healthCheck/HealthCheck.js
- /src/node_modules/@mojaloop/central-services-shared/src/healthCheck/index.js
- /src/node_modules/@mojaloop/central-services-shared/src/index.js
- /src/InboundServer/middlewares.js
- /src/InboundServer/index.js
- /src/index.js
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at Object.<anonymous> (/src/node_modules/@mojaloop/central-services-shared/src/healthCheck/HealthCheck.js:30:16)
at Module._compile (internal/modules/cjs/loader.js:1063:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Module.require (internal/modules/cjs/loader.js:952:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/src/node_modules/@mojaloop/central-services-shared/src/healthCheck/HealthCheck.js',
'/src/node_modules/@mojaloop/central-services-shared/src/healthCheck/index.js',
'/src/node_modules/@mojaloop/central-services-shared/src/index.js',
'/src/InboundServer/middlewares.js',
'/src/InboundServer/index.js',
'/src/index.js'
]
}

Severity:
High

Priority:
Medium

Expected Behavior
SDK-scheme-adapter should start up and pass GP tests.

Steps to Reproduce

  1. Deploy Mojaloop Helm v13.0.2 Release Candidate
  2. Monitor sim-*-scheme-adapter pods
  3. The pods will fail readinessProbe/livenessProbe checks which will result in the pods being restarted, thereby ending in a state of "CrashLoopBackOff".

Specifications

  • Component (if known): Sdk-scheme-adapter
  • Version: v11.18.5
  • Platform: Kubernetes
  • Subsystem: Helm
  • Type of testing: Manual
  • Bug found/raised by: @mdebarros

Notes:

  • Severity when opened: High
  • Priority when opened: Medium
@mdebarros mdebarros added bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it labels Aug 26, 2021
@mdebarros mdebarros self-assigned this Aug 26, 2021
@elnyry-sam-k elnyry-sam-k added this to the Sprint 15.2 milestone Aug 26, 2021
@mdebarros mdebarros mentioned this issue Aug 26, 2021
Merged
mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Aug 26, 2021
@mdebarros
Merge pull request #282 from mdebarros/fix/#2433-sdk-scheme-adapter-v…
3c50416 
…11.18.5-release-failing-on-startup

fix(mojaloop/#2433): sdk-scheme-adapter v11.18.5 release fails to start
- Updated .gitignore with devspace, logs and IGNORE patterns
- Moved @mojaloop peerDependencies to dependencies. Generally we would only add the @mojaloop dependencies as peerDependencies to libraries, but in this case the sdk-scheme-adapter is a standalone service, and as a result should not be a dependency to any other service. This fixes [mojaloop/#2433](mojaloop/project#2433).
- Upgraded all dependencies except [ws v8.x](https://github.com/websockets/ws/releases/tag/8.0.0), which has some breaking changes. This will need to be addressed in future. `ws` was upgraded to the latest 7.x compatible version for the time being.
@mdebarros mdebarros reopened this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
bug Something isn't working or it has wrong behavior on a Mojaloop Core service oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it
Projects
None yet
Milestone
Sprint 15.2
Development

Successfully merging a pull request may close this issue.

fix(mojaloop/#2433): sdk-scheme-adapter v11.18.5 release fails to start mdebarros/sdk-scheme-adapter
2 participants
@elnyry-sam-k @mdebarros