-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install.sh script? #342
Comments
Hi @vorburger this would be amazing. In fact, @tdaly61 and I have been working on https://github.com/tdaly61/mini-loop, which contains pretty much the scripts you are looking for, which some hacks to get around the issues with older kubernetes versions. (Take a look here) |
I'll finish turning master...vorburger:minishift into such a PR after #348 is merged. |
Hi @vorburger , hey I am sort of following the idea here but not entirely sure. |
Co-authored-by: Lewis Daly <[email protected]>
Ok I took ownership of this as it seems to be inactive and without assignee. I am not sure of the status of the previous work but I think the original submitter Vorburger had the right idea. Anyhow for now I have essentially implemented this functionality in the form of mini-loop. I intend to make a pull request shortly against the helm charts repo and seek to move the main mini-loop functions into the helm charts under a /install directory. At that stage I think this ticket coould be taken off of backlog and closed ... unless someone has better ideas. |
How about "scripting" https://docs.mojaloop.io/documentation/deployment-guide/#4-helm and https://docs.mojaloop.io/documentation/deployment-guide/#5-mojaloop ?
I'm thinking nothing fancy, just a good ol' bash script... and then put that into the root of this repo, and simplify the Deployment Guide to "run this script" instead of those ca. 10 manual steps.
This would also make "testing" something like mojaloop/documentation#236 easier - one would just run this new script to see if it works.
I'm willing to contribute to the project and raise a PR for this, if this seems useful to you? I just need to first be able to get it running manually - I'm currently stuck at #341.
PS: Perhaps this could even be the beginning of more fancy automated test of these Helm charts (in a next step)? Like a
./test.sh
which calls this script but also creates a completely clean new Kube env from scratch and see if everything works. Then we can hook that up to check for each PR.The text was updated successfully, but these errors were encountered: