Fix infinite expanding error list #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve reliability of integration tests by using ML TS client.
Justification of this implementation: these error lists shouldn't be long; therefore functionality available with DataList such as pagination, search and sort is redundant. Use a plain table instead. This doesn't solve the underlying issue with DataList, but as the issue doesn't seem to exist with other usage of DataList and we don't need it for this purpose, this will suffice for now.
Note for potential future readers: the problem seems to be caused by an ever-expanding bounding rectangle and computed styles in ScrollBox here: https://github.com/modusintegration/modusbox-ui-components/blob/21983a45e626080fc91e5872c0f8de1d36ad87f4/src/components/ScrollBox/ScrollBox.js#L61. It does not occur when DataList is inside a different element, i.e. when it's used to display the settlement or settlement window list.