Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mojaloop/#3656): sequence diagrams and pages for FX transfer (ML-API-Adapter) #434

Merged
merged 14 commits into from
Jan 29, 2025
Merged

feat(mojaloop/#3656): sequence diagrams and pages for FX transfer (ML-API-Adapter) #434

merged 14 commits into from
Jan 29, 2025

Conversation

oderayi
Copy link
Contributor

@oderayi oderayi commented Mar 29, 2024 •
edited
Loading

  • added sequence diagrams and pages for FX transfers

@oderayi oderayi marked this pull request as draft March 29, 2024 10:13
@oderayi oderayi changed the title feat(mojaloop/#3656): sequence diagrams for FX transfer feat(mojaloop/#3656): sequence diagrams for FX transfer (ML-API-Adapter) Mar 29, 2024
@oderayi oderayi marked this pull request as ready for review April 2, 2024 09:52
@oderayi oderayi changed the title feat(mojaloop/#3656): sequence diagrams for FX transfer (ML-API-Adapter) feat(mojaloop/#3656): sequence diagrams and pages for FX transfer (ML-API-Adapter) Apr 2, 2024
elnyry-sam-k
elnyry-sam-k previously approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@elnyry-sam-k elnyry-sam-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oderayi ; very comprehensive and well done, also addressing issues that we took for granted, earlier.

@elnyry-sam-k elnyry-sam-k mentioned this pull request Nov 13, 2024
Merged
@elnyry-sam-k
Copy link
Member

@oderayi , can you please look at this PR again and see whats needed to merge? if nothing, please re-request a review

@oderayi oderayi requested a review from elnyry-sam-k January 21, 2025 12:13
elnyry-sam-k
elnyry-sam-k previously approved these changes Jan 27, 2025
View reviewed changes
@oderayi oderayi requested a review from elnyry-sam-k January 29, 2025 08:54
@oderayi oderayi merged commit e76c5af into master Jan 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elnyry-sam-k elnyry-sam-k elnyry-sam-k approved these changes

@bushjames bushjames Awaiting requested review from bushjames bushjames is a code owner

@mdebarros mdebarros Awaiting requested review from mdebarros

@millerabel millerabel Awaiting requested review from millerabel millerabel is a code owner

@PaulMakinMojaloop PaulMakinMojaloop Awaiting requested review from PaulMakinMojaloop PaulMakinMojaloop is a code owner

@simeonoriko simeonoriko Awaiting requested review from simeonoriko simeonoriko is a code owner

@vijayg10 vijayg10 Awaiting requested review from vijayg10 vijayg10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oderayi @elnyry-sam-k