Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created discussion doc #137

Merged
merged 1 commit into from
Nov 20, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions discussions/code_improvement.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Code_Improvement Project

## Overview
Purpose to improve code quality and security for the Mojaloop project. Includes analysis and introduction of new open sources tools, process improvments, gates checks (w/in pull requests and builds) along with documentation.

Scope: project is focused on quality and security but can lead to other areas such as test automation and DevOps automation and tools.

## OutPut (phase one by end of January):
- Implementation and analysis of new OSS tools
- Update Release Scripts: Security aspects need to be embedded in release/devops (CI/CD)
- Update rules for Pull Requests: Security aspects embedded in pull requests (before check-ins)
- Update documentations: Standards and contribution guides

Slack Channel:#code_security

## Discussions:
### Implement changes at the Dockerfile and CI/CD build process to help bolster our container security
- Create a non-root user within the Dockerfile
- Enable docker-content-trust on the docker host (this will be inside CircleCI)
- Run builds with --no-cache during CircleCI step to ensure that we are pulling in any new security patches each time (I don’t think this is a major issue since we don’t have CircleCI docker image caching on anyway

### Move from Javascript to Typescript
- Transition to typescript (mix and match js and ts) for more security/quality
- Typescript is preferred but not required: https://github.com/mojaloop/template-typescript-public