fix(csi-977): updated CorrelationId format to support UUID and ULID #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geka-evk
requested review from
mdebarros,
elnyry-sam-k,
vijayg10,
kleyow,
bushjames and
oderayi
as code owners
geka-evk
commented
Dec 4, 2024
| format, conforming to RFC 4122, that is restricted by a regular expression | ||
| for interoperability reasons. An UUID is always 36 characters long, 32 hexadecimal | ||
| symbols and 4 dashes (‘-‘). | ||
| pattern: ^[0-9a-f]{8}-[0-9a-f]{4}-[1-7][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$|^[0-9A-HJKMNP-TV-Z]{26}$ |
There was a problem hiding this comment.
api-snippets already has this change:
https://github.com/mojaloop/api-snippets/blob/main/fspiop/v2_0/openapi3/components/schemas/CorrelationId.yaml#L3
|
vijayg10
approved these changes
Dec 4, 2024
kleyow
added a commit
that referenced
this pull request
Jan 17, 2025
* feat(csi-164): parameterize 'switch' id (#482) * fix(csi-241): fixed unit-tests (#483) * fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * test: temporarily disable int test shutdown * fix: update parameters for sendRequest and update tests * chore: update deps, re-enable int test shutdown --------- Co-authored-by: Steven Oderayi <[email protected]> * chore(snapshot): 15.4.0-snapshot.0 * chore(snapshot): 15.4.0-snapshot.1 * chore(snapshot): 15.4.0-snapshot.2 * chore(snapshot): 15.4.0-snapshot.3 * chore(snapshot): 15.4.0-snapshot.4 * chore(snapshot): 15.4.0-snapshot.5 * chore(snapshot): 15.4.0-snapshot.6 * chore(snapshot): 15.4.0-snapshot.7 * chore(snapshot): 15.4.0-snapshot.8 * chore(snapshot): 15.4.0-snapshot.9 * chore(snapshot): 15.4.0-snapshot.10 * chore(snapshot): 15.4.0-snapshot.11 * chore(snapshot): 15.4.0-snapshot.12 * chore(csi-16): updated deps * chore(snapshot): 15.4.0-snapshot.13 * feat(csi-16): added proxy caching logic (#484) * fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * fix(csi-241): fixed unit-tests * feat(csi-16): refactoring - moved getPartiesByTypeAndID to a separate file * ci: fix docker build * feat(csi-263): implemented getPartiesByTypeAndID proxy changes (#485) * feat(csi-263): implemented getPartiesByTypeAndID proxy changes * feat(csi-263): implemented getPartiesByTypeAndID proxy changes * feat(csi-263): update npm test:... scripts * feat(csi-263): added networks to redis in d-c * feat(csi-263): added proxyCache logic for success PUT /parties * feat(csi-263): added proxyCache logic for error PUT /parties * feat(csi-263): updated proxyConfig format * feat(csi-263): added jest-unit.config.js * feat(csi-215): updated test-harness version to use fx * chore(snapshot): 15.4.0-snapshot.0 * chore(snapshot): 15.4.0-snapshot.1 * chore(snapshot): 15.4.0-snapshot.2 * chore(snapshot): 15.4.0-snapshot.3 * chore(snapshot): 15.4.0-snapshot.4 * chore(snapshot): 15.4.0-snapshot.5 * chore(snapshot): 15.4.0-snapshot.6 * chore(snapshot): 15.4.0-snapshot.7 * chore(snapshot): 15.4.0-snapshot.8 * chore(snapshot): 15.4.0-snapshot.9 * chore(snapshot): 15.4.0-snapshot.10 * chore(snapshot): 15.4.0-snapshot.11 * feat: make proxy routing optional & update health check (#486) * chore(csi-16): updated central-services-shared version * chore(snapshot): 15.4.0-snapshot.12 * chore(snapshot): 15.4.0-snapshot.13 * chore(snapshot): 15.4.0-snapshot.14 * chore(csi-16): inited proxies cache * chore(snapshot): 15.4.0-snapshot.15 * chore(snapshot): 15.4.0-snapshot.16 * feat(csi-263): added proxy int-test from parties handler * feat(csi-263): added proxy int-test from parties handler * feat(csi-263): added --runInBand to unit tests * feat(csi-16): proxyCacheTtlSec = 40 * chore(snapshot): 15.4.0-snapshot.17 * feat(csi-16): proxyCacheTtlSec = 40 * feat(csi-16): proxyCacheTtlSec = 40 * chore(snapshot): 15.4.0-snapshot.18 * Update docker/account-lookup-service/default.json Co-authored-by: Steven Oderayi <[email protected]> * Update test/integration-config.json Co-authored-by: Steven Oderayi <[email protected]> --------- Co-authored-by: Steven Oderayi <[email protected]> * feat(csi-334): e2e als-proxy flow validation (#487) * feat(csi-263): implemented getPartiesByTypeAndID proxy changes * feat(csi-263): implemented getPartiesByTypeAndID proxy changes * feat(csi-263): update npm test:... scripts * feat(csi-263): added networks to redis in d-c * feat(csi-263): added proxyCache logic for success PUT /parties * feat(csi-263): added proxyCache logic for error PUT /parties * feat(csi-263): updated proxyConfig format * feat(csi-263): added jest-unit.config.js * feat(csi-215): updated test-harness version to use fx * chore(snapshot): 15.4.0-snapshot.0 * chore(snapshot): 15.4.0-snapshot.1 * chore(snapshot): 15.4.0-snapshot.2 * chore(snapshot): 15.4.0-snapshot.3 * chore(snapshot): 15.4.0-snapshot.4 * chore(snapshot): 15.4.0-snapshot.5 * chore(snapshot): 15.4.0-snapshot.6 * chore(snapshot): 15.4.0-snapshot.7 * chore(snapshot): 15.4.0-snapshot.8 * chore(snapshot): 15.4.0-snapshot.9 * chore(snapshot): 15.4.0-snapshot.10 * chore(snapshot): 15.4.0-snapshot.11 * feat: make proxy routing optional & update health check (#486) * chore(csi-16): updated central-services-shared version * chore(snapshot): 15.4.0-snapshot.12 * chore(snapshot): 15.4.0-snapshot.13 * chore(snapshot): 15.4.0-snapshot.14 * chore(csi-16): inited proxies cache * chore(snapshot): 15.4.0-snapshot.15 * chore(snapshot): 15.4.0-snapshot.16 * feat(csi-263): added proxy int-test from parties handler * feat(csi-263): added proxy int-test from parties handler * feat(csi-263): added --runInBand to unit tests * feat(csi-16): proxyCacheTtlSec = 40 * chore(snapshot): 15.4.0-snapshot.17 * feat(csi-16): proxyCacheTtlSec = 40 * feat(csi-16): proxyCacheTtlSec = 40 * chore(snapshot): 15.4.0-snapshot.18 * Update docker/account-lookup-service/default.json Co-authored-by: Steven Oderayi <[email protected]> * Update test/integration-config.json Co-authored-by: Steven Oderayi <[email protected]> * feat(csi-334): added source to proxyCache for payee case * chore(snapshot): 15.4.0-snapshot.19 * feat(csi-334): added axios-retry * chore(snapshot): 15.4.0-snapshot.20 * fix(csi-321): fixed failed GP tests * chore(snapshot): 15.4.0-snapshot.21 * fix(csi-321): fixed case of sendCallback to requester * chore(snapshot): 15.4.0-snapshot.22 * fix(csi-321): added contextLogger * fix(csi-334): add proxyLib with redis-cluster * chore(snapshot): 15.4.0-snapshot.23 * fix(csi-334): add proxyLib with redis-cluster * chore(snapshot): 15.4.0-snapshot.24 * fix(csi-334): fixed config * chore(snapshot): 15.4.0-snapshot.25 * fix(csi-334): used new proxyLib --------- Co-authored-by: Steven Oderayi <[email protected]> * fix(csi-334): switched to redis standalone; improved logging; added int-test * fix(csi-334): improved logging * chore(snapshot): 15.4.0-snapshot.26 * fix(csi-418): fixed oracle update logic; added tests (#490) * fix(csi-418): fixed oracle update logic; added tests * chore(snapshot): 15.4.0-snapshot.27 * fix(csi-418): fixed oracle update logic; added tests * chore(snapshot): 15.4.0-snapshot.28 * feat: PROXY_MAP * chore(snapshot): 15.4.0-snapshot.29 * feat(mojaloop/#4000): timeout handler (#489) --------- Co-authored-by: Steven Oderayi <[email protected]> Co-authored-by: Kalin Krustev <[email protected]> * chore: deps * feat(csi-106): added support for ISO headers (#493) * feat(csi-106): added support for ISO headers * feat(csi-106): added ISO20022 snippets for parties callback * feat(csi-106): updated deps * feat(csi-106): updated deps * feat(csi-106): added transform lib * feat(csi-106): updated Timeout handler to support ISO format * feat(csi-106): disabled TransformFacades unit-tests * feat(csi-106): node lts * feat(csi-106): node lts * feat(csi-106): added support for ISO headers * feat(csi-106): fixed int-tests * feat(csi-106): fixed int-tests * feat(csi-106): fixed int-tests * feat(csi-106): fixed int-tests * feat(csi-106): fixed int-tests * fix(csi-746): passed apiType to sendRequest (#495) * fix(csi-746): passed apiType to sendRequest * fix(csi-746): passed apiType to sendRequest * fix(csi-746): fixed int test * fix(csi-746): fixed int test * fix(csi-746): fixed int test * fix(csi-746): fixed int test * fix(csi-746): fixed int test * fix(csi-746): fixed int test * fix(csi-746): fixed int test * chore(snapshot): 15.5.0-snapshot.2 * test: start using mojaloop/build orb (#496) * chore(release): [ci skip] 15.5.0-iso.0 * chore: version * chore(release): [ci skip] 15.6.0-iso.1 * feat(csi-106): updated transformLib * chore: continuous deployment * Updated config.yml * chore(release): [ci skip] 15.6.0-iso.2 * feat(csi-106): added support for ISO headers (#493) (#494) * feat(csi-106): updated transformLib * feat(csi-106): added logging to participant sendRequest * feat(csi-106): added logging to participant sendRequest * feat(csi-106): mojaloop/[email protected] * chore(release): [ci skip] 15.6.0-iso.3 * feat(csi-106): fixed GP tests (#498) feat(csi-106): reorder logging plugin * chore(release): [ci skip] 15.6.0-iso.4 * fix(csi-809): fixed ISO header from hub (#499) * feat(csi-106): reorder logging plugin * fix(csi-809): fixed ISO header from hub * chore(release): [ci skip] 15.6.0-iso.5 * fix(csi-809): fixed circular structure to JSON error * chore(release): [ci skip] 15.6.0-iso.6 * chore(release): [ci skip] 15.6.0-iso.7 * chore: update api spec and dependencies (#501) * chore: unit tests * chore: unit tests * chore: revert * chore(release): [ci skip] 15.6.0-iso.8 * fix(csi-421): misleading error with participant validation (#502) * chore(release): [ci skip] 15.6.0-iso.9 * chore: test * chore(release): [ci skip] 15.6.0-iso.10 * fix(csi-910): fixed error callback in case of oracle error (#503) * fix(csi-910): fixed error callback in case of oracle error * fix(csi-910): fixed test:functional * fix(csi-910): fixed test:functional * fix(csi-910): cleaned up * chore(snapshot): 15.6.0-snapshot.0 * chore(snapshot): 15.6.0-snapshot.1 * chore(snapshot): 15.6.0-snapshot.2 * fix(csi-910): updated request with error log * chore(snapshot): 15.6.0-snapshot.3 * fix(csi-910): used logger.child instead of loggerFactory * chore(snapshot): 15.6.0-snapshot.4 * fix(csi-910): used logger.child instead of loggerFactory * chore(release): [ci skip] 15.6.0-iso.11 * chore: use the central-services-metrics plugin (#504) * chore(release): [ci skip] 15.6.0-iso.12 * chore: update dependencies * chore(release): [ci skip] 15.6.0-iso.13 * fix(csi-938): fixed POST /participants callback with error info (#505) * fix(csi-938): fixed POST /participants callback with error info * fix(csi-938): fixed logging in domain/participants * chore(release): [ci skip] 15.6.0-iso.14 * chore: update dependencies * chore(release): [ci skip] 15.6.0-iso.15 * chore: update dependencies * chore(release): [ci skip] 15.6.0-iso.16 * chore: add version to metrics (#507) * chore(release): [ci skip] 15.6.0-iso.17 * fix(csi-977): updated CorrelationId format to support UUID and ULID (#508) * chore(release): [ci skip] 15.6.0-iso.18 * fix(csi-980): fixed FSPIOP_SOURCE_TO_SIGN config to be able to set fspio-signature header (#510) * fix(csi-980): fixed FSPIOP_SOURCE_TO_SIGN config to be able to set fspio-signature header * fix(csi-980): fixed FSPIOP_SOURCE_TO_SIGN config to be able to set fspio-signature header * chore(release): [ci skip] 15.6.0-iso.19 * feat(csi-927): switched to use loggingPlugin (#511) feat(csi-927): switched to use loginPlugin * chore(release): [ci skip] 15.6.0-iso.20 * feat: add error count metrics (#509) * chore(release): [ci skip] 15.6.0-iso.21 * fix: audit proper variable in error counter (#512) * chore(release): [ci skip] 15.6.0-iso.22 * chore(csi-1051): added log (#515) * chore(release): [ci skip] 15.6.0-iso.23 * feat: call DB assertPendingAcquires for GET /parties (#514) * chore(release): [ci skip] 15.6.0-iso.24 * fix: monorepo (#517) * chore(release): [ci skip] 15.6.0-iso.25 * chore(release): [ci skip] 16.1.0-iso.0 * chore: todos * chore(release): [ci skip] 16.1.0-iso.1 --------- Co-authored-by: Steven Oderayi <[email protected]> Co-authored-by: Eugen Klymniuk <[email protected]> Co-authored-by: geka.evk <[email protected]> Co-authored-by: Kalin Krustev <[email protected]> Co-authored-by: mojaloopci <[email protected]> Co-authored-by: vijayg10 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.