Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend service principal migration to create storage credentials for … #2

Merged
merged 1 commit into from
May 6, 2024

Conversation

mohanab-db
Copy link
Owner

…access connectors created for each storage account (databrickslabs#1426)

Changes

Extend service principal migration to create storage credentials for access connectors created for each storage account

Linked issues

Resolves databrickslabs#1384
Resolves databrickslabs#875

To do

  • Update docs on creating access connectors.
  • First prompt for creating credentials for access connectors, then for service princpals
  • Use the storage credentials in external locations

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs ucx ...
  • added a new workflow
  • modified existing workflow: ...
  • added a new table
  • modified existing table: ...

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

Changes

Linked issues

Resolves #..

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs ucx ...
  • added a new workflow
  • modified existing workflow: ...
  • added a new table
  • modified existing table: ...

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

…access connectors created for each storage account (#1426)

## Changes
Extend service principal migration to create storage credentials for
access connectors created for each storage account

### Linked issues

Resolves #1384 
Resolves #875

### To do
- [x] Update docs on creating access connectors. 
- [x] First prompt for creating credentials for access connectors, then
for service princpals
- [x] Use the storage credentials in [external
locations](https://github.com/databrickslabs/ucx/blob/main/src/databricks/labs/ucx/azure/locations.py#L65)

### Functionality 

- [ ] added relevant user documentation
- [ ] added new CLI command
- [x] modified existing command: `databricks labs ucx ...`
- [ ] added a new workflow
- [ ] modified existing workflow: `...`
- [ ] added a new table
- [ ] modified existing table: `...`

### Tests
<!-- How is this tested? Please see the checklist below and also
describe any other relevant tests -->

- [x] manually tested
- [x] added unit tests
- [x] added integration tests
- [ ] verified on staging environment (screenshot attached)

---------

Co-authored-by: Serge Smertin <[email protected]>
Co-authored-by: vuong-nguyen <[email protected]>
@mohanab-db mohanab-db merged commit edfeaf1 into mohanab-db:main May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants