[WIP] Attempt hold-tap implementation of Magic key #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expects a keymap file as the POST body
Wrap compilation with ccache, and prepare a pre-warmed cache of the build in /tmp/ccache. To maximize chance of a direct cache hit, change the lambda driver to always build in /tmp/build. some back of the envelope measurements (2012 xeon e3-1230v2, nixos) clean build, no cache -> 21.308 clean build, cache -> 7.145 modified keymap, clean build, cache -> 12.127
Does not yet include magic key hold-tap behaviour for the underglow status
chrisandreae
force-pushed
the
keymap-development
branch
from
2b77eb5 to
1053b9b
Compare
chrisandreae
force-pushed
the
main
branch
2 times, most recently
from
a68bae8 to
a9417f3
Compare
yuanbin
pushed a commit
to yuanbin/zmk
that referenced
this pull request
Jun 14, 2023
* Add Contra Shield (moergo-sc#1) * Add bluetooth control layer to contra keymap (moergo-sc#2) * fix contra keymap issues * add bluetooth control layer * clean up contra files * add contra.conf file * add missing bracket for default_layer * update copyright year to 2021 * add contra metadata file * refactor pro micro overlay for new syntax
chrisandreae
pushed a commit
to chrisandreae/zmk
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a hold-tap implementation of the magic key, which presently can't work because
zmk,behavior-hold-tapdemands two binding cells, and passes one each to its child bindings, while&rgb_ugitself requires two binding cells.We'll have to work around this by adding a new
&indicatorbehaviour that takes one argument, to be compatible with hold-tap.