Skip to content

Commit

Permalink
fix: permadiff issue when docker_repository field is not specified …
Browse files Browse the repository at this point in the history 
…(#9850)

relates to GoogleCloudPlatform/cloud-foundation-fabric#1987
When docker repository is not specified by default docker repository`projects/PROJECT_ID/locations/REGION/repositories/gcf-artifacts` is used.In such a case, terraform plan always generates a difference for `docker_repository`field as the module passes null value but the tfstate file has the above specifieddefault value. This fix allows one to prevent unnecessary infrastructure change.
[upstream:3540e663502c1286967dd61650bb8ee7c2b35cf9]

Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
@modular-magician
modular-magician committed Jan 22, 2024
1 parent f8952e9 commit 4da3df2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion go.mod
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ require (
github.com/hashicorp/hcl/v2 v2.19.1
github.com/hashicorp/terraform-json v0.17.1
github.com/hashicorp/terraform-plugin-sdk/v2 v2.29.0
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240122212345-ec99f1c61906
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240122222421-b5182cb3a456
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.8.4
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ github.com/hashicorp/terraform-plugin-log v0.9.0/go.mod h1:rKL8egZQ/eXSyDqzLUuwU
github.com/hashicorp/terraform-plugin-mux v0.8.0 h1:WCTP66mZ+iIaIrCNJnjPEYnVjawTshnDJu12BcXK1EI=
github.com/hashicorp/terraform-plugin-sdk/v2 v2.29.0 h1:wcOKYwPI9IorAJEBLzgclh3xVolO7ZorYd6U1vnok14=
github.com/hashicorp/terraform-plugin-sdk/v2 v2.29.0/go.mod h1:qH/34G25Ugdj5FcM95cSoXzUgIbgfhVLXCcEcYaMwq8=
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240122212345-ec99f1c61906 h1:D43g7DiWgvdxADVkdwU7repeD7n8nnS929laZOpgc0s=
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240122212345-ec99f1c61906/go.mod h1:80URE3tt9ME1zSgd7JGDlJ3nWw1tFBK/R5eltuYRfaI=
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240122222421-b5182cb3a456 h1:QAYGc8VYYfeI0YNjFqRamkajxkatBTpVWe5QLYDY3PQ=
github.com/hashicorp/terraform-provider-google-beta v1.20.1-0.20240122222421-b5182cb3a456/go.mod h1:80URE3tt9ME1zSgd7JGDlJ3nWw1tFBK/R5eltuYRfaI=
github.com/hashicorp/terraform-registry-address v0.2.2 h1:lPQBg403El8PPicg/qONZJDC6YlgCVbWDtNmmZKtBno=
github.com/hashicorp/terraform-registry-address v0.2.2/go.mod h1:LtwNbCihUoUZ3RYriyS2wF/lGPB6gF9ICLRtuDk7hSo=
github.com/hashicorp/terraform-svchost v0.1.1 h1:EZZimZ1GxdqFRinZ1tpJwVxxt49xc/S52uzrw4x0jKQ=
Expand Down

0 comments on commit 4da3df2

Please sign in to comment.