-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: rename workflow names, revise uv setup, fix python versions #2435
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2435 +/- ##
=========================================
+ Coverage 68.4% 76.3% +7.8%
=========================================
Files 294 294
Lines 59390 59936 +546
=========================================
+ Hits 40652 45741 +5089
+ Misses 18738 14195 -4543 |
uses: astral-sh/setup-uv@v5 | ||
with: | ||
version: "0.5.18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they also say to keep the version locked, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this mentioned. It defaults to the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, you're probably thinking of this usage doc for setup-pixi. I'd be inclined to lock this for setup-uv if it proves to be instable. On the plus side, I see very active version turn-over fixing bugs with both uv and setup-uv that I wouldn't anticipate too much instability (or short-lived instability, if any).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been on a uv learning quest for the past few weeks too! As for the
However, generally I share the same view that lockfiles are more for applications than libraries, thus I"m somewhat neutral/undecided at this stage. Was this lockfile creating any issues or confusion in this repo? |
No, it's just big, and it introduces the question of when to update it. All at once, every once in a while, I guess is the pattern for "applications". But I figured better to get an early warning when a dependency breaks for a library? |
Aggrege it's a big and unpleasant-looking file to add to version control. I don't know the protocol of updating it either, but I'll try to look out for this etiquette. There is a convenient-looking uv-pre-commit that keeps this updated at all times. |
This PR does the following:
actions/setup-python
whereastral-sh/setup-uv
is used (mind you, both can be used according to docs)uvx
to run uv tools likeruff
andtwine
; this may eventually phase-out thebuild
andlint
extras in pyproject.tomluv publish
instead of pypa/gh-action-pypi-publishetc/github-develop-requirements.txt
for the GitHub-linked source installs, using preferred "git+https" protocolsastral-sh/setup-uv
action, specify eithercache-dependency-glob: "**/pyproject.toml"
orenable-cache: false
to disable warning messages