Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language tags to code blocks #67

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Add language tags to code blocks #67

merged 7 commits into from
Oct 10, 2023

Conversation

adrhill
Copy link
Collaborator

@adrhill adrhill commented Sep 24, 2023

No description provided.

@gdalle
Copy link
Collaborator

gdalle commented Sep 26, 2023

Can I recommend adding all our custom CSS to the custom.css file, in order to make it easier to separate? That's what I've been trying to do after we switched templates, but I fear you might have already snuck some custom code inside franklin.css when I wasn't looking

@adrhill
Copy link
Collaborator Author

adrhill commented Sep 26, 2023

Then let me also try to move old custom code to custom.css. :)

@gdalle
Copy link
Collaborator

gdalle commented Oct 6, 2023

Mini bump on this @adrhill since people are starting to take an interest

@gdalle
Copy link
Collaborator

gdalle commented Oct 6, 2023

I think the easiest is to create a new Franklin website and do a git diff of the css files

@adrhill
Copy link
Collaborator Author

adrhill commented Oct 10, 2023

I'm not sure this pure CSS approach with ::before is the best solution, as it doesn't allow for "floating" tags that don't scroll with the code.

However it does the job for now and is easily customisable (and we can still replace it later).

@adrhill
Copy link
Collaborator Author

adrhill commented Oct 10, 2023

Preview on Chrome:
Screenshot 2023-10-10 at 17 27 42

Preview on Safari:
Screenshot 2023-10-10 at 17 28 17

@gdalle
Copy link
Collaborator

gdalle commented Oct 10, 2023

Looks awesome! Ship it!

@adrhill adrhill merged commit 610e613 into main Oct 10, 2023
@adrhill adrhill deleted the ah/language-tags2 branch October 10, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants