Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance for align offset harness #89

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

carolynzech
Copy link

Currently, this harness takes 21 minutes in CI. The only point of this harness is to verify the contract for pointee types with a non-power of two byte size--17 was an arbitrary choice. Reducing to 5 and changing the solver reduces verification time to 57 seconds on my local machine.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@carolynzech carolynzech requested a review from a team as a code owner September 18, 2024 20:58
Copy link

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo @tautschnig comments.

@carolynzech carolynzech enabled auto-merge (squash) September 20, 2024 17:41
@carolynzech carolynzech merged commit 35e78b7 into model-checking:main Sep 24, 2024
7 checks passed
szlee118 pushed a commit to stogaru/verify-rust-std that referenced this pull request Oct 17, 2024
Currently, this harness takes 21 minutes in CI. The only point of this
harness is to verify the contract for pointee types with a non-power of
two byte size--17 was an arbitrary choice. Reducing to 5 and changing
the solver reduces verification time to 57 seconds on my local machine.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
@carolynzech carolynzech deleted the align-offset-perf branch October 22, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants