Add scripts for local subtree update #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add pull_request just for testing add push permission for testing Test without updating subtree Try within kani dir Use kani as workdir Change parsing Parse regex with path Check for toolchain file Get toolchain date Use correct hash and date Use commit hash instead make upstream pull explicit Add origin for pulling set working directory to head Fix working directory Update subtree Add --quiet Update with --quiet Add pull_from_upstream.sh Add scripts -1 Add explicit commit pull Add temp home dir Add clone from temp Add base repo Update comments clone into tempdir Add working tests
Let me update this PR itself with that change. |
Test with github workspace Try with bash Run ls Try with path expanded Fix path to script Fix path to library Fix script Check with verify-rst-std Check workflow Check path Fix path change path to head
tautschnig
reviewed
Aug 5, 2024
tautschnig
approved these changes
Aug 6, 2024
Closed
szlee118
pushed a commit
to stogaru/verify-rust-std
that referenced
this pull request
Oct 17, 2024
The CI job for subtree update timesout because it takes more than 6hrs. While we figure out how to solve that problem, this process makes sure there's an automated way for anyone to update the repo's subtree hosted library, with a one click script/command. The structure of this process follows the (would-be) CI workflow closely i.e 1. Call `scripts/run_update_with_checks.sh` 2. This script in turn calls the other scripts in order 3. Pull and update local `subtree/library` with updates from [rust-lang](https://github.com/rust-lang/rust) 4. Merge `subtree/library` onto local `SYNC-{DATE}` where {DATE} is the date tracked by Kani's `features/verify-rust-std` branch. 5. Update toolchain to the date tracked by kani's `features/verify-rust-std` branch and commit. 6. Test this branch with `check_rustc` which checks for compilation compatibility of the updated library and `check_kani` which checks that Kani's injected harnesses verify as expected. ## Call-out This currently only automates the process of updating the subtree and running all checks on it. After that, the process of issuing a PR from the SYNC-DATE branch of the local repo is still in the responsibility of the dev running the script. There is ongoing work to automate the process of writing/pushing branches as well. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI job for subtree update timesout because it takes more than 6hrs. While we figure out how to solve that problem, this process makes sure there's an automated way for anyone to update the repo's subtree hosted library, with a one click script/command.
The structure of this process follows the (would-be) CI workflow closely i.e
scripts/run_update_with_checks.shsubtree/librarywith updates from rust-langsubtree/libraryonto localSYNC-{DATE}where {DATE} is the date tracked by Kani'sfeatures/verify-rust-stdbranch.features/verify-rust-stdbranch and commit.check_rustcwhich checks for compilation compatibility of the updated library andcheck_kaniwhich checks that Kani's injected harnesses verify as expected.Call-out
This currently only automates the process of updating the subtree and running all checks on it. After that, the process of issuing a PR from the SYNC-DATE branch of the local repo is still in the responsibility of the dev running the script.
There is ongoing work to automate the process of writing/pushing branches as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.