Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain upgrade to nightly-2025-01-28 #3855

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

feliperodri
Copy link
Contributor

@feliperodri feliperodri commented Jan 26, 2025

Resolves #3854.

This upgrade requires changes to remove RunCompiler due to the following changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@feliperodri feliperodri added [C] Internal Tracks some internal work. I.e.: Users should not be affected. Z-BenchCI Tag a PR to run benchmark CI labels Jan 26, 2025
@feliperodri feliperodri requested a review from a team as a code owner January 26, 2025 21:56
Copy link
Contributor

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR description with the upstream changes that made these changes necessary (and fix the regression failures)?

@feliperodri feliperodri self-assigned this Jan 27, 2025
@feliperodri feliperodri changed the title Toolchain upgrade to nightly-2025-01-26 Toolchain upgrade to nightly-2025-01-27 Jan 27, 2025
@feliperodri
Copy link
Contributor Author

feliperodri commented Jan 27, 2025

Currently this is blocked by rust-lang/rust@0cffe5c. Expect to get this by tomorrow when upgrade to 2025-01-28. This is the same issue as described by rust-lang/rust#136086.

Signed-off-by: Felipe R. Monteiro <[email protected]>
@feliperodri feliperodri changed the title Toolchain upgrade to nightly-2025-01-27 Toolchain upgrade to nightly-2025-01-28 Jan 28, 2025
@feliperodri
Copy link
Contributor Author

This is the only significant regression in performance from the logs

2025-01-28T19:08:25.6886916Z benchcomp: WARNING: Benchmark 's2n-quic/quic/s2n-quic-platform/message::msg::tests::handle_get_set_test' regressed on metric 'solver_runtime' (22.01801 -> 118.50720600000001)
2025-01-28T19:08:25.6887928Z benchcomp: WARNING: Benchmark 'smol_str/check_new' regressed on metric 'solver_runtime' (80.13497000000001 -> 137.7696)

@celinval celinval added this pull request to the merge queue Jan 28, 2025
Merged via the queue into model-checking:main with commit ecbdb14 Jan 28, 2025
27 of 28 checks passed
@feliperodri feliperodri deleted the toolchain-upgrade branch January 28, 2025 22:47
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2025
Github generated release notes:

## What's Changed
* Automatic toolchain upgrade to nightly-2025-01-08 by @github-actions
in #3821
* Automatic cargo update to 2025-01-13 by @github-actions in
#3824
* Automatic toolchain upgrade to nightly-2025-01-09 by @github-actions
in #3825
* Bump ncipollo/release-action from 1.14.0 to 1.15.0 by @dependabot in
#3826
* Bump tests/perf/s2n-quic from `ac52a48` to `adc7ba9` by @dependabot in
#3827
* Automatic toolchain upgrade to nightly-2025-01-10 by @github-actions
in #3828
* Automatic toolchain upgrade to nightly-2025-01-11 by @github-actions
in #3830
* Verify contracts/stubs for generic types with multiple inherent
implementations by @carolynzech in
#3829
* Update Charon submodule by @thanhnguyen-aws in
#3823
* Automatic toolchain upgrade to nightly-2025-01-12 by @github-actions
in #3831
* Automatic toolchain upgrade to nightly-2025-01-13 by @github-actions
in #3833
* Upgrade toolchain to 2025-01-15 by @tautschnig in
#3835
* Automatic toolchain upgrade to nightly-2025-01-16 by @github-actions
in #3836
* Add a regression test for `no_std` feature by @carolynzech in
#3837
* Use fully-qualified name for size_of by @zhassan-aws in
#3838
* Automatic cargo update to 2025-01-20 by @github-actions in
#3842
* Bump tests/perf/s2n-quic from `adc7ba9` to `f0649f9` by @dependabot in
#3844
* Upgrade toolchain to nightly-2025-01-22 by @tautschnig in
#3843
* Remove `DefKind::Ctor` from filtering crate items by @carolynzech in
#3845
* Enable valid_ptr post_condition harnesses by @tautschnig in
#3847
* Update build command in docs to use release mode by @zhassan-aws in
#3846
* Automatic toolchain upgrade to nightly-2025-01-23 by @github-actions
in #3848
* Automatic toolchain upgrade to nightly-2025-01-24 by @github-actions
in #3850
* Remove the openssl-devel package from dependencies by @zhassan-aws in
#3852
* Fix validity checks for `char` by @celinval in
#3853
* Bump tests/perf/s2n-quic from `f0649f9` to `4500593` by @dependabot in
#3857
* Automatic cargo update to 2025-01-27 by @github-actions in
#3856
* Deprecate `--enable-unstable` and `--restrict-vtable` by @celinval in
#3859
* Stub linker to avoid missing symbols errors by @celinval in
#3858
* Toolchain upgrade to nightly-2025-01-28 by @feliperodri in
#3855
* Allow multiple annotations, but check for duplicate targets. by
@remi-delmas-3000 in #3808
* Move documentation of kani_core modules to right places by @qinheping
in #3851
* Fix missing function declaration issue by @celinval in
#3862
* Fix transmute codegen when sizes are different by @celinval in
#3861
* Remove symtab2gb from bundle by @zhassan-aws in
#3865
* Update the rustc hack for CLion / RustRover by @celinval in
#3868
* Bump tests/perf/s2n-quic from `4500593` to `82dd0b5` by @dependabot in
#3872
* Automatic cargo update to 2025-02-03 by @github-actions in
#3869
* Add reference for loop contracts by @qinheping in
#3849
* remove flag float-overflow-check by @rajath-mk in
#3873

## New Contributors
* @rajath-mk made their first contribution in
#3873

**Full Changelog**:
kani-0.58.0...kani-0.59.0



By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

---------

Co-authored-by: Zyad Hassan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected. Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolchain upgrade to nightly-2025-01-25 failed
3 participants