Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few issues with std verification #3255

Merged
merged 4 commits into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions kani-driver/src/call_cargo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,19 @@ impl KaniSession {
.env("CARGO_TERM_PROGRESS_WHEN", "never")
.env("__CARGO_TESTS_ONLY_SRC_ROOT", std_path.as_os_str());

let build_artifacts = self.run_build(cmd)?;
Ok(build_artifacts.into_iter().filter_map(map_kani_artifact).collect())
Ok(self
.run_build(cmd)?
.into_iter()
.filter_map(|artifact| {
if artifact.target.crate_types.contains(&CRATE_TYPE_LIB.to_string())
|| artifact.target.crate_types.contains(&CRATE_TYPE_RLIB.to_string())
{
map_kani_artifact(artifact)
} else {
None
}
})
.collect())
}

/// Calls `cargo_build` to generate `*.symtab.json` files in `target_dir`
Expand Down
83 changes: 79 additions & 4 deletions library/kani_core/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#![no_core]

mod arbitrary;
mod mem;

pub use kani_macros::*;

Expand All @@ -34,15 +35,21 @@ macro_rules! kani_lib {
#[cfg(kani)]
#[unstable(feature = "kani", issue = "none")]
pub mod kani {
pub use kani_core::{ensures, proof, proof_for_contract, requires, should_panic};
kani_core::kani_intrinsics!();
pub use kani_core::{
ensures, modifies, proof, proof_for_contract, requires, should_panic,
};
kani_core::kani_intrinsics!(core);
kani_core::generate_arbitrary!(core);

pub mod mem {
kani_core::kani_mem!(core);
}
}
};

(kani) => {
pub use kani_core::*;
kani_core::kani_intrinsics!();
kani_core::kani_intrinsics!(std);
kani_core::generate_arbitrary!(std);
};
}
Expand All @@ -54,7 +61,7 @@ macro_rules! kani_lib {
/// TODO: Use this inside kani library so that we dont have to maintain two copies of the same intrinsics.
#[macro_export]
macro_rules! kani_intrinsics {
() => {
($core:tt) => {
/// Creates an assumption that will be valid after this statement run. Note that the assumption
/// will only be applied for paths that follow the assumption. If the assumption doesn't hold, the
/// program will exit successfully.
Expand Down Expand Up @@ -262,6 +269,74 @@ macro_rules! kani_intrinsics {
}

pub mod internal {

/// Helper trait for code generation for `modifies` contracts.
///
/// We allow the user to provide us with a pointer-like object that we convert as needed.
#[doc(hidden)]
pub trait Pointer<'a> {
/// Type of the pointed-to data
type Inner;

/// Used for checking assigns contracts where we pass immutable references to the function.
///
/// We're using a reference to self here, because the user can use just a plain function
/// argument, for instance one of type `&mut _`, in the `modifies` clause which would move it.
unsafe fn decouple_lifetime(&self) -> &'a Self::Inner;

/// used for havocking on replecement of a `modifies` clause.
unsafe fn assignable(self) -> &'a mut Self::Inner;
}

impl<'a, 'b, T> Pointer<'a> for &'b T {
type Inner = T;
unsafe fn decouple_lifetime(&self) -> &'a Self::Inner {
$core::mem::transmute(*self)
}

#[allow(clippy::transmute_ptr_to_ref)]
unsafe fn assignable(self) -> &'a mut Self::Inner {
$core::mem::transmute(self as *const T)
}
}

impl<'a, 'b, T> Pointer<'a> for &'b mut T {
type Inner = T;

#[allow(clippy::transmute_ptr_to_ref)]
unsafe fn decouple_lifetime(&self) -> &'a Self::Inner {
$core::mem::transmute::<_, &&'a T>(self)
}

unsafe fn assignable(self) -> &'a mut Self::Inner {
$core::mem::transmute(self)
}
}

impl<'a, T> Pointer<'a> for *const T {
type Inner = T;
unsafe fn decouple_lifetime(&self) -> &'a Self::Inner {
&**self as &'a T
}

#[allow(clippy::transmute_ptr_to_ref)]
unsafe fn assignable(self) -> &'a mut Self::Inner {
$core::mem::transmute(self)
}
}

impl<'a, T> Pointer<'a> for *mut T {
type Inner = T;
unsafe fn decouple_lifetime(&self) -> &'a Self::Inner {
&**self as &'a T
}

#[allow(clippy::transmute_ptr_to_ref)]
unsafe fn assignable(self) -> &'a mut Self::Inner {
$core::mem::transmute(self)
}
}

/// A way to break the ownerhip rules. Only used by contracts where we can
/// guarantee it is done safely.
#[inline(never)]
Expand Down
Loading
Loading