Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain to nightly-2023-09-05 #2734

Merged

Conversation

adpaco-aws
Copy link
Contributor

@adpaco-aws adpaco-aws commented Sep 5, 2023

Description of changes:

Manually updates toolchain to nightly-2023-09-05. The main change is documentation-related, to avoid the warnings (which get upgraded to compilation errors when running kani-regression.sh) that are now produced because of this change.

Testing:

  • How is this change tested? Existing regression.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws added the Z-BenchCI Tag a PR to run benchmark CI label Sep 5, 2023
@adpaco-aws adpaco-aws requested a review from a team as a code owner September 5, 2023 20:01
@adpaco-aws adpaco-aws force-pushed the update-toolchain-2023-09-05 branch from f97d12a to 96a3773 Compare September 5, 2023 20:02
@jaisnan
Copy link
Contributor

jaisnan commented Sep 5, 2023

Why is the error from cargo doc only showing up now?

@adpaco-aws
Copy link
Contributor Author

Apologies, the errors don't come from cargo doc. Please check the updated description, but it's basically due to this change in rustc.

Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adpaco-aws adpaco-aws merged commit 0ec046c into model-checking:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants