-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a playback command to make it easier to run Kani generated tests #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
zhassan-aws
reviewed
May 23, 2023
tests/script-based-pre/concrete_playback_e2e/sample_crate/src/lib.rs
Outdated
Show resolved
Hide resolved
tests/script-based-pre/cargo_playback_opts/sample_crate/src/lib.rs
Outdated
Show resolved
Hide resolved
zhassan-aws
approved these changes
May 24, 2023
celinval
added a commit
that referenced
this pull request
May 25, 2023
Update the description of how to use concrete playback to incorporate the recent changes, including PR #2464
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Introduce the unstable subcommand
playback
to allow users to easily compile and run their test cases that were generated using Kani's concrete playback feature.This is the help for this subcommand (I redacted the details of options that already exist today):
Resolved issues:
Resolves #2440
Resolves #1441
Resolves #1581
Related RFC:
N/A
Call-outs:
cfg(test)
#1577 but I haven't tested it yet, so I'm not claiming victory.Testing:
How is this change tested? New unit tests and end to end tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.