Move all rustc arguments to kani-driver #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. It's good to have one source of truth. 2. This is needed for us to properly support caching compiler artifacts.
We need to at least set the panic strategy for this to succeed. I removed the harness here since we don't try to execute it, and this is really just trying to run code generation.
zhassan-aws
reviewed
Feb 2, 2023
| @@ -50,8 +50,7 @@ cd std_lib_test | |||
|
|
|||
| # Add some content to the rust file including an std function that is non-generic. | |||
| echo ' | |||
| #[kani::proof] | |||
There was a problem hiding this comment.
So we don't have to manually inject Kani dependency here. Since our goal for this script is to make sure we can generate code for the standard library, this seems much easier to maintain than duplicating a bunch of the compiler flags here.
| @@ -68,7 +67,7 @@ echo "Starting cargo build with Kani" | |||
| export RUST_BACKTRACE=1 | |||
| export RUSTC_LOG=error | |||
| export KANIFLAGS="--goto-c --ignore-global-asm --reachability=legacy" | |||
| export RUSTFLAGS="--kani-flags" | |||
| export RUSTFLAGS="--kani-flags -C panic=abort" | |||
There was a problem hiding this comment.
I had to change this because in this script we are invoking kani-compiler via cargo build not via cargo kani. This is the only relevant flag for the codegen to go through.
zhassan-aws
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Move all rustc arguments to kani-driver
Resolved issues:
None. It's part of #2137 and needed for #2036.
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested? Current tests
Is this a refactor change? Yes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.