-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to postgres range fields #80
Conversation
@anapaulagomes and @amureki I think we can relase a new version of model bakery once we merge this. Although, the ideal release would also have #81 fixed and merged in. |
Sounds good to me. But @berinhard did you mean #81 or another issue? |
Yep, because while working on this PR to fix the issue #70, I noticed that there were other range types besides In my opinion, a more consistent release would cover all range fields, so that's why I think it would be nice for us to have #81 fixed as well =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these fields to Model Bakery, @berinhard! 🏅 I've got only minor comments and one question about letting DecimalRangeField
separated from the other fields added.
Co-authored-by: Ana Paula Gomes <[email protected]>
Co-authored-by: Ana Paula Gomes <[email protected]>
@anapaulagomes I've updated this PR and also fixed the conflict in the Changelog. Can you review it again, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🏆
@anapaulagomes sorry but by the time you've left your approval, I was adding support to |
@amureki can you review this PR? @anapaulagomes will be offline for a while, so it's up to the 2 of us to keep on with the project =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Bernardo!
Great work, this is definitely needed change. :)
I had some small comments to be checked, feel free to drop me a line about those!
(follow-up to #80) Co-authored-by: Rust Saiargaliev <[email protected]>
Fixes #70
Fixes #81
This PR add supports to Postgres's range fields.