Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and test regression in 1.18.3 forbidding setting GFK by a function #515

Merged
merged 3 commits into from
Feb 11, 2025
Merged

fix and test regression in 1.18.3 forbidding setting GFK by a function #515

merged 3 commits into from
Feb 11, 2025

Conversation

PetrDlouhy
Copy link
Contributor

@PetrDlouhy PetrDlouhy commented Jan 23, 2025 •
edited
Loading

Describe the change
Fix regression #516, add test

PR Checklist

  • Change is covered with tests
  • CHANGELOG.md is updated if needed

@PetrDlouhy PetrDlouhy mentioned this pull request Jan 23, 2025
Closed
@PetrDlouhy PetrDlouhy force-pushed the pr/gfk_function_set_test branch from 132228e to 0501aac Compare January 23, 2025 13:34
@PetrDlouhy PetrDlouhy marked this pull request as ready for review January 23, 2025 13:38
@PetrDlouhy PetrDlouhy changed the title test for setting GFK by a function fix and test regression in 1.18.3 forbidding setting GFK by a function Jan 24, 2025
amureki
amureki approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you for digging into this issue (and I apologize for breaking it!) and adding a regression test. 👍

@amureki amureki merged commit 52355a8 into model-bakers:main Feb 11, 2025
10 checks passed
amureki added a commit to PetrDlouhy/model_bakery that referenced this pull request Feb 11, 2025
@amureki
Merge remote-tracking branch 'origin/main' into pr/gfk_proxy_regression
a339805 
* origin/main:
  Fix model-bakers#516 -- fix regression forbidding setting GFK by a function (model-bakers#515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amureki amureki amureki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PetrDlouhy @amureki