Switch to tox-travis #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 3, 2019 21:04
anapaulagomes
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
This package is really cool and the numbers are impressive! Well done, @amureki. 🏆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds official Travis package, called
tox-travis(https://tox-travis.readthedocs.io/en/stable/) to simplify test suite.Previously we defined complicated matrix in travis config to run all possible version and service variations we have. Now this package handles all that, we only need to specify which python versions to run against. This looks much cleaner and simpler to maintain.
Also, now it uses 3 jobs instead of 14, which reduces running time from ~11 minutes down to ~4 minutes.
Total run time reduced from ~27 minutes to ~11 minutes.
Linting tasks are running under python 3.6 environment since version does not really matter here (instead of having expensive separate job).
And I need to mention a small positive bug fix that I accidentaly made here. PostgreSQL tests were not running after switching to Travis matrix (shame on me):
https://travis-ci.com/model-bakers/model_bakery/jobs/262622958
Now they do run properly. :)