Get ManyToOneRel fields (reverse FK) back to work #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timjklein36
approved these changes
Mar 31, 2022
Co-authored-by: Tim Klein <[email protected]>
Co-authored-by: Tim Klein <[email protected]>
|
Thanks for the fixes @timjklein36! As a non english speaker, they are always welcome =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291
Given the way Django's
Model.save()works, the code was breaking when trying to prepared (viabaker.prepare) objects which hold FK for other prepared instances. Thesavecall only persists the current model and not the subsequent ones.Meanwhile, django manager's
setoraddmethods does handle nested persistence, but doesn't know how to save models which doesn't hold other FKs (or at least this is what I understood from the issue).So, this PR introduces a fixes to only save an object before adding it to the related model if it doesn't have any FK. Other scenarios should now be handled by Django