Add explanations to imports in generators.py
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amureki
force-pushed
the
cleaned_up_model_imports
branch
2 times, most recently
from
16c7e98 to
bb966ba
Compare
amureki
changed the title
generators.pygenerators.py
amureki
force-pushed
the
cleaned_up_model_imports
branch
from
bb966ba to
0b32575
Compare
berinhard
approved these changes
Apr 17, 2021
There was a problem hiding this comment.
Thanks for reducing the confusion within the imports by adding these comments @amureki! I'mm with @anapaulagomes in the changelog comment, but besides that this is good work
added 2 commits
April 17, 2021 16:43
To match with currently supported Django versions (2.2+).
amureki
force-pushed
the
cleaned_up_model_imports
branch
from
0b32575 to
78ef789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match with currently supported Django versions (2.2+).