Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Add Github Actions for package releasing #168

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Mar 29, 2021

Adds an automated action based on GitHub releases to simplify PyPI release process.

@amureki amureki self-assigned this Mar 29, 2021
@amureki
Copy link
Collaborator Author

amureki commented Mar 29, 2021

@berinhard hey Bernardo! Would you mind checking this one and adding secrets in repo settings, if this is okay with you?

For example, after we merge this and set up secrets, possible next steps for the release would be:

This will trigger a GitHub Action to publish a new release in PyPI.

@amureki amureki requested a review from berinhard March 29, 2021 12:10
@amureki amureki assigned berinhard and unassigned amureki Mar 29, 2021
Copy link
Member

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @amureki this looks great! it opens path to any collaborator to release new versions, not just me.

would you or @anapaulagomes be comfortable with that? IMHO, this PR makes the deploy process more solid than it's now and less riskier. we could create a model-bakers user in pypi as well, right? so our personal pypi keys won't be needed. what do you think?

@berinhard berinhard merged commit b1293f9 into main Apr 1, 2021
@berinhard berinhard deleted the gha_release branch April 1, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants