Drop obsolete model_bakery.timezone.now
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2021 21:36
And use `django.utils.timezone.now` instead. Refs #35.
amureki
force-pushed
the
issues/35/drop_custom_now
branch
from
d513fcf to
2ec3eac
Compare
amureki
requested review from
anapaulagomes and
berinhard
and removed request for
anapaulagomes
anapaulagomes
approved these changes
Feb 13, 2021
|
@anapaulagomes now I wonder if this would target the right audience here. :) Also, we are not officially supporting it since long, haha, so I think this is just good to go as it is now. |
|
Feel free to merge this @amureki |
This was referenced Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to do smaller steps to tackle #35 :)
It should be simpler to review-iterate now.
P.S. I wonder if this should be considered as a breaking change, but I doubt anyone who switched to
model_bakerywas using Django 1.4 and was importing this method.P.P.S. Tests did fail due to the
setup.pyimport issue. I put a separate PR for them: #142 and rebased this one on top of that branch. So the only meaningful here is the first commit: 2ec3eac. To simplify review, I changed base branch toabout, which will be switched tomainautomatically after #142 would be merged.