Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce: Cannot call baker.make() with ForeignKey default=pk, only actual model instance #137

Closed
wants to merge 10 commits into from
Closed

Reproduce: Cannot call baker.make() with ForeignKey default=pk, only actual model instance #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
01c38c9
Add a test to reproduce problem described in #136
cb109 Dec 9, 2020
db3ceec
Pass instance instead of pk as default for ForeignKey field
cb109 Dec 9, 2020
e486247
Handle ForeignKey.to_field when retrieving default FK instance
cb109 Dec 9, 2020
8723a96
Fix typo
cb109 Dec 9, 2020
cef7415
Shorten kwargs setup
cb109 Dec 9, 2020
85f9d3f
Revert "Shorten kwargs setup"
cb109 Dec 9, 2020
4075aa0
Revert "Fix typo"
cb109 Dec 9, 2020
e48d3a6
Revert "Handle ForeignKey.to_field when retrieving default FK instance"
cb109 Dec 9, 2020
412774d
Revert "Pass instance instead of pk as default for ForeignKey field"
cb109 Dec 9, 2020
5e331e4
Wrap lines
cb109 Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions tests/generic/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,23 @@ class DummyGenericRelationModel(models.Model):
relation = GenericRelation(DummyGenericForeignKeyModel)


class NamedThing(models.Model):
name = models.CharField(max_length=64)


def get_default_namedthing_id():
instance, _ = NamedThing.objects.get_or_create(name="Default")
return instance.id


class DummyForeignKeyWithDefaultIdModel(models.Model):
named_thing = models.ForeignKey(
"NamedThing",
default=get_default_namedthing_id,
on_delete=models.SET_DEFAULT,
)


class DummyNullFieldsModel(models.Model):
null_foreign_key = models.ForeignKey(
"DummyBlankFieldsModel", null=True, on_delete=models.CASCADE
Expand Down
9 changes: 9 additions & 0 deletions tests/test_filling_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,15 @@ def test_filling_content_type_field(self):
assert dummy.content_type.model_class() is not None


@pytest.mark.django_db
class TestFillingForeignKeyFieldWithDefaultFunctionReturningId:
def test_filling_foreignkey_with_default_id(self):
dummy = baker.make(
models.DummyForeignKeyWithDefaultIdModel, named_thing__name="Default"
)
assert dummy.named_thing.id == models.get_default_namedthing_id()


@pytest.mark.django_db
class TestsFillingFileField:
def test_filling_file_field(self):
Expand Down