Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type support and mypy checking #100

Merged
merged 22 commits into from
Oct 5, 2020
Merged

Add type support and mypy checking #100

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d180999
Add type support and mypy checking
palfrey Sep 2, 2020
704af6b
Don't need models direct import
palfrey Sep 2, 2020
91b7946
Simplify some auto-generated types
palfrey Sep 2, 2020
06baa9d
Merge branch 'master' into typed
palfrey Sep 5, 2020
e34c6da
Pull mypy settings into config
palfrey Sep 5, 2020
4706fad
Disallow untyped calls
palfrey Sep 5, 2020
ea4f8ce
Make type annotations 3.5 compatible
palfrey Sep 5, 2020
370a0e4
Remove ModelBase usage
palfrey Sep 5, 2020
f4d6c26
Explicitly run mypy in tox
palfrey Sep 5, 2020
d54890a
Python 3.5 needs typing_extensions
palfrey Sep 5, 2020
6519444
Correct ModelBase usage
palfrey Sep 5, 2020
a729326
Cope with inference from union types
palfrey Sep 5, 2020
71fe587
Deal with new action_generator work in tests
palfrey Sep 5, 2020
f48ade2
Don't use test class in main code!
palfrey Sep 5, 2020
1b7a9d8
_skip_field can use Field
palfrey Sep 5, 2020
519eeb0
Loosen typing-extensions requirement
palfrey Sep 5, 2020
4bc7c10
Fix create_files attribute
palfrey Sep 13, 2020
529df43
Fix unique/ambiguous_models types
palfrey Sep 13, 2020
c8e137e
Rip out action_generator
palfrey Sep 13, 2020
e6ce7c6
Don't need typing-extensions any more
palfrey Sep 13, 2020
ecdbf44
Merge branch 'master' into typed
palfrey Sep 26, 2020
84c61dc
Added changelog entry for type annotations
palfrey Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't use test class in main code!
  • Loading branch information
@palfrey
palfrey committed Sep 5, 2020
commit f48ade21b6cc9333d20f751e5dd4af3e48556809
4 changes: 1 addition & 3 deletions model_bakery/baker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
)
from django.db.models.fields.reverse_related import ManyToOneRel, OneToOneRel

from tests.generic.fields import CustomForeignKey

from . import generators, random_gen
from .exceptions import (
AmbiguousModelName,
Expand Down Expand Up @@ -493,7 +491,7 @@ def _handle_m2m(self, instance: Model):
make(through_model, **base_kwargs)

def _remote_field(
self, field: Union[CustomForeignKey, ForeignKey, OneToOneField]
self, field: Union[ForeignKey, OneToOneField]
) -> Union[OneToOneRel, ManyToOneRel]:
return field.remote_field

Expand Down