Change the flight plan tolerance and steps to be consistent with the prediction #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
approved these changes
Aug 20, 2022
ksp_plugin_adapter/flight_planner.cs
Outdated
| parameters.length_integration_tolerance.ToString( | ||
| "0.0e0")), | ||
| length_integration_tolerances_names_[ | ||
| length_integration_tolerance_index_]), |
There was a problem hiding this comment.
Just remove the localized string (also from the localization files).
ksp_plugin_adapter/flight_planner.cs
Outdated
| private static readonly string[] speed_integration_tolerances_names_ = { | ||
| "1 µm/s", "10 µm/s", "100 µm/s", "1 mm/s", "1 cm/s", "10 cm/s", "1 m/s", | ||
| "10 m/s", "100 m/s", "1 km/s", "10 km/s", "100 km/s", "1000 km/s" | ||
| }; |
There was a problem hiding this comment.
Unused, remove.
Also remove this TODO in the main window :
Principia/ksp_plugin_adapter/main_window.cs
Line 430 in 5c17d25
Let’s not go there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3395.