Use static styles to prevent Unity leaks #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
approved these changes
Nov 13, 2021
|
Thank you very much for figuring out the issue! & I love the meme (I shared the sentiment regarding Unity while collecting & observing the dozens of gflags procdump traces under different conditions: "Unity_Player.dll is responsible for 1.01 GBytes of outstanding allocations"... ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the save given in #3064 burns about 120 MiB/minute when the flight planner UI is visible. After this PR, it uses about 10 MiB/minute. Note that we do expect some memory growth due to Principia as the trajectories of the celestials and vessels are extended.
Fix #3064.