Show nodes with respect to the equator #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
requested changes
May 18, 2019
ksp_plugin/plugin.cpp
Outdated
| &*renderer_->GetPlottingFrame()); | ||
| if (cast_plotting_frame != nullptr) { | ||
| auto const& plotting_frame = *cast_plotting_frame; | ||
| auto const centre = dynamic_cast_not_null<RotatingBody<Barycentric> const*>( |
There was a problem hiding this comment.
Do *dynamic_cast_not_null and you'll avoid all the -> below.
There was a problem hiding this comment.
I dynamic_cast_not_null<OblateBody<Barycentric> const*>(centre) below, and that becomes &dynamic_cast<OblateBody<Barycentric> const&>(centre), which, being passed as a not_null parameter, induces a gratuitous nullness check.
Do we want that?
pleroy
reviewed
May 18, 2019
pleroy
reviewed
May 18, 2019
pleroy
approved these changes
May 19, 2019
| @@ -192,13 +218,13 @@ public enum NodeSource { | |||
| properties.object_type == MapObject.ObjectType.Periapsis | |||
| ? "Periapsis" | |||
| : "Apoapsis"; | |||
| CelestialBody celestial = properties.celestial; | |||
| CelestialBody celestial = | |||
| properties.reference_frame.selected_celestial; | |||
| caption.captionLine2 = | ||
| $"{speed:N0} m/s".ToString(Culture.culture); | ||
| break; | ||
| } | ||
| case MapObject.ObjectType.PatchTransition: { | ||
| CelestialBody celestial = | ||
| properties.reference_frame.selected_celestial; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1841.