Update required node and npm versions #85
Conversation
Just update the documentation to remove support for node `<4`. The current version of `mocha` pulls in dependencies which use arrow functions which fail in earlier versions of node. See https://travis-ci.org/sirreal/mocha/builds/299600162, where I forked `mocha` and added tests for earlier versions.
If node v4 is required, it's silly to require npm@1.
|
|
|
Good catch, thanks! @mochajs/core do we want to hold off on this till we resolve mochajs/mocha#3073? We should also make a note that, after this repo is rolled into the other (mochajs/mocha#2987), this ought to be automatically generated from |
|
@ScottFreeCode I'm just manually pulling this stuff in |
|
@sirreal Can you please sign the CLA? |
|
merging this with mochajs/mocha#3123 anyway |
I've been hoping to but actually can't. I have a preexisting agreement with an organization. My organization has been in touch with the JSF about the CLA but as far as I know there's been no response, which is what I'm waiting on. 🤷♂️ |
|
cc @krisborchers can you help? |
|
errr @kborchers |
|
@sirreal @boneskull We were contacted by your org on November 12 and I responded on November 13 with details around how our CLA works and a potential option for corporate CLA but have not heard back from them. |
|
Thanks for the info, I'll check on my end to try to get some movement. |
This PR updates the documentation to support for node
>=4and npm>=2.14.2.The current version of
mochapulls in dependencies which use arrow functions which fail in earlier versions of node.See https://travis-ci.org/sirreal/mocha/builds/299600162, where I forked
mochaand added tests for earlier versions.If node 4 is required, it seems to make sense to report
[email protected]as the minimum version since that is what shipped with node v4.