Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run netlify with Node 16 #4778

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Run netlify with Node 16 #4778

merged 2 commits into from
Jan 19, 2022

Conversation

outsideris
Copy link
Contributor

@outsideris outsideris commented Oct 25, 2021 •
edited by juergba
Loading

Netlify runs on node 12, but 12 is a pretty old version.

  • I updated it to Node 16
  • supporter.js: replace rmdir by rm
  • netlify settings: load netlify build image focal instead of xenial

@coveralls
Copy link

coveralls commented Oct 25, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 94.428% when pulling 83b59fc on outsideris:netlify-node-version into 3b4cc05 on mochajs:master.

@outsideris outsideris force-pushed the netlify-node-version branch from a724ec5 to d205f49 Compare November 6, 2021 08:13
@outsideris outsideris force-pushed the netlify-node-version branch 4 times, most recently from 515a922 to 83b59fc Compare December 31, 2021 11:40
@juergba
Copy link
Contributor

juergba commented Jan 17, 2022

@outsideris Node v12 will be end-of-life on 2022-04-30. Are you working on this one?

Could you grant Netlify access to me, please?

@outsideris
Copy link
Contributor Author

@juergba Yes, I didn't find yet why our build is failed on Netlify and Node 16.

@outsideris
Copy link
Contributor Author

@juergba Let me know your email address. Maybe via gitter?

@juergba
Copy link
Contributor

juergba commented Jan 19, 2022 •
edited
Loading

Evtl. it helps to use the newer netlify build image focal, see here.
Our build is still running on the old xenial, which runs on Ubuntu 16.04.

Edit: I switched to focal and it still fails.

@juergba juergba force-pushed the netlify-node-version branch from 83b59fc to 67e46c1 Compare January 19, 2022 15:10
@juergba juergba force-pushed the netlify-node-version branch from 6c141af to 429f1fa Compare January 19, 2022 15:26
@juergba juergba marked this pull request as ready for review January 19, 2022 15:35
@juergba juergba mentioned this pull request Jan 19, 2022
Closed
@juergba juergba merged commit 9fbf3ae into mochajs:master Jan 19, 2022
@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. area: documentation anything involving docs or mochajs.org labels Jan 19, 2022
@juergba juergba added this to the next milestone Jan 19, 2022
@outsideris
Copy link
Contributor Author

Awesome!!

KuznetsovRoman pushed a commit to gemini-testing/mocha that referenced this pull request Sep 6, 2022
@outsideris @juergba @KuznetsovRoman
chore: run Netlify deploy on Node v16 (mochajs#4778) [ci skip]
4545c69 
Signed-off-by: Outsider <[email protected]>
Co-authored-by: Juerg B <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba approved these changes

Assignees
No one assigned
Labels
area: documentation anything involving docs or mochajs.org type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v9.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@outsideris @coveralls @juergba