Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(unit/runner.spec.js): Minor tweeks related to #3686 #3704

Merged
merged 5 commits into from
Feb 1, 2019
Merged

test(unit/runner.spec.js): Minor tweeks related to #3686 #3704

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e69f348
test(unit/runner.spec.js): Minor tweeks related to #3686
plroebuck Jan 30, 2019
f920930
test(unit/runner.spec.js): Make wording consistent between two tests
plroebuck Jan 30, 2019
2bb0011
test(unit/runner.spec.js): Fixes and upgrades
plroebuck Jan 31, 2019
6f125b1
test(unit/runner.spec.js): Skip stacktrace filter tests in browser
plroebuck Jan 31, 2019
9e36ddc
test(unit/runner.spec.js): Skip existential operator checks
plroebuck Feb 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 26 additions & 21 deletions test/unit/runner.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
'use strict';

var fs = require('fs');
var path = require('path');
var mocha = require('../../lib/mocha');
var Suite = mocha.Suite;
var Runner = mocha.Runner;
var Test = mocha.Test;
var Hook = mocha.Hook;
var path = require('path');
var fs = require('fs');
var noop = mocha.utils.noop;

describe('Runner', function() {
Expand Down Expand Up @@ -454,7 +454,7 @@ describe('Runner', function() {

describe('shortStackTrace', function() {
beforeEach(function() {
if (path.sep !== '/') {
if (process.platform === 'win32') {
plroebuck marked this conversation as resolved.
Show resolved Hide resolved
this.skip();
}
});
Expand All @@ -476,7 +476,7 @@ describe('Runner', function() {

describe('longStackTrace', function() {
beforeEach(function() {
if (path.sep !== '/') {
if (process.platform === 'win32') {
this.skip();
}
});
Expand All @@ -500,28 +500,31 @@ describe('Runner', function() {

describe('hugeStackTrace', function() {
beforeEach(function() {
if (path.sep !== '/') {
if (process.platform === 'win32') {
this.skip();
}
});

it('should not hang if the error message is ridiculously long single line', function(done) {
function genOverlongSingleLineMessage() {
var data = [];
for (var i = 0; i < 10000; i++) {
data[i] = {a: 1};
}
return JSON.stringify(data);
}

it('should not hang if overlong error message is single line', function(done) {
var hook = new Hook();
hook.parent = suite;
var data = [];
// mock a long message
for (var i = 0; i < 10000; i++) data[i] = {a: 1};
var message = JSON.stringify(data);
var message = genOverlongSingleLineMessage();
var err = new Error();
// Fake stack-trace
err.stack = [message].concat(stack).join('\n');

runner.on('fail', function(hook, err) {
var filteredErrStack = err.stack.split('\n').slice(1);
expect(
err.stack
.split('\n')
.slice(1)
.join('\n'),
filteredErrStack.join('\n'),
'to be',
stack.slice(0, 3).join('\n')
);
Expand All @@ -530,21 +533,23 @@ describe('Runner', function() {
runner.failHook(hook, err);
});

it('should not hang if error message is ridiculously long multiple lines either', function(done) {
function genOverlongMultiLineMessage() {
var fpath = path.join(__dirname, '..', '..', 'mocha.js');
return fs.readFileSync(fpath, 'utf8');
}

it('should not hang if overlong error message is multiple lines', function(done) {
var hook = new Hook();
hook.parent = suite;
var fpath = path.join(__dirname, '../../mocha.js');
var message = fs.readFileSync(fpath, 'utf8');
var message = genOverlongMultiLineMessage();
var err = new Error();
// Fake stack-trace
err.stack = [message].concat(stack).join('\n');

runner.on('fail', function(hook, err) {
var filteredErrStack = err.stack.split('\n').slice(-3);
expect(
err.stack
.split('\n')
.slice(-3)
.join('\n'),
filteredErrStack.join('\n'),
'to be',
stack.slice(0, 3).join('\n')
);
Expand Down