Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to test before afterAll hook runs #2008

Closed
wants to merge 1 commit into from

Conversation

stonelgh
Copy link

Fix #2006

Review on Reviewable

@danielstjules
Copy link
Contributor

Given the example from #2006

describe('good test', function() {
  it('should not blame me', function() { });
});

describe('bad test', function() {
  before('fail init', function() {
    throw new Error();
  });

  it('skipped');
});
// Before PR:
1) bad test "before all" hook: fail init for "should not blame me":
// After PR:
1) bad test "before all" hook: fail init:

Looks good :) @stonelgh Could you add a test for this in https://github.com/mochajs/mocha/blob/master/test/integration/hook.err.js ? The fixture could just about be the code from your original issue.

@danielstjules
Copy link
Contributor

Oh, didn't need to open a new PR - but I'll close this in favor of #2028 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants