Fix ICMP and UDP traceroute #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Scott <[email protected]>
Signed-off-by: David Scott <[email protected]>
An ICMP datagram with TTL exceeded contains a truncated copy of the original IPv4 datagram. In our case this will contain a truncated ICMP echo request. This patch parses the packet and rewrites both the destination and the id in the nested copy because - the destination we receive from the host will have the host's IP in it, we need to use the VM's IP - the id we receive from the host is chosen by us in the NAT translation, so we have to translate it back With these changes, ICMP traceroute works. Signed-off-by: David Scott <[email protected]>
We expect to receive ICMP when the TTL on the outgoing packets is exceeded. This patch forwards these ICMP messages to the application. Note this exposes a a global mapping of external UDP port number to internal address, introducing a dependency from the Hostnet_icmp module to the Hostnet_udp. Signed-off-by: David Scott <[email protected]>
When using UDP traceroute the client expects to receive a "Destination unreachable" from the final target. Signed-off-by: David Scott <[email protected]>
|
Nice - I guess this also fixes #194, at least partially |
|
@MagnusS good point. Although it's not 100% fixed it's probably good enough for most people, so I think I'll declare it fixed with caveats. |
This was referenced Nov 2, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes ICMP and UDP traceroute (on Mac) by:
On windows we don't receive the ICMP messages for an unknown reason.
Fixes #193
Fixes #194