Skip to content

mount: add go.mod #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2020
Merged

mount: add go.mod #3

merged 1 commit into from
Mar 17, 2020

Conversation

kolyshkin
Copy link
Collaborator

The version of golang.org/x/sys corresponds to the one currently used
by Moby.

Once there, it needs to be tagged, e.g.

git tag mount/v0.1.0

The version of golang.org/x/sys corresponds to the one currently used
by Moby.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Collaborator Author

@thaJeztah PTAL

@thaJeztah
Copy link
Member

are we sure we want mount and mountinfo to be separate modules, and to be tagged separately? (wondering how much they will evolve separately)

@kolyshkin
Copy link
Collaborator Author

are we sure we want mount and mountinfo to be separate modules, and to be tagged separately? (wondering how much they will evolve separately)

The main reason to separate it was that mountinfo is not dependent on anything (except go std lib), while mount depends on golang.org/x/sys/unix and mountinfo. So, if someone wants to use mountinto only, they don't have to pull any extra deps.

The reason for separate tagging is this is how you do it in a repo with multiple modules (https://github.com/golang/go/wiki/Modules#faqs--multi-module-repositories). This also allows to bump a single module without affecting others.

@kolyshkin kolyshkin mentioned this pull request Mar 17, 2020
@kolyshkin
Copy link
Collaborator Author

Merging to unblock tagging and CI

@kolyshkin kolyshkin merged commit 20f06c7 into moby:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants